Skip to content

feat(comparison): preserve exact native sources and verified saved evidence - #91

Merged
MrScripty merged 12 commits into
mainfrom
implementation/configurable-native-m3-integration-20261015
Oct 15, 2026
Merged

MrScripty merged 12 commits into
mainfrom
implementation/configurable-native-m3-integration-20261015

Conversation

@MrScripty

@MrScripty MrScripty commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Cold native comparisons need exact source identities and reproducible derived evidence. Add public native-field analysis, immutable recipes/results, and actual desktop/run-set navigation on existing SQLite/run-set owners. Align explicit publications by actual time/stage and exact geometry; retain unmatched/unavailable coverage, native metrics/common bounds and explicit pressure-gauge diagnostics. Cold results remain Unverified until exact pins/selections are reopened and the whole result recomputed.

Stacked on #88; selected only reviewed companion files. Actual app/tests use public recording::comparison. compared_values reuses the exact existing reduction/gauge and retains native cell/face dimensions, offsets and physical geometry. Explicit page materialization reopens both exact archives/identities and matches the verified summary; no numerical/worker/store duplication. Public raw samples retain the overflow guard. Independent review closed assertion stripping in the new pointwise oracle using explicit failures and perturbed-sample checks in normal/-O/PYTHONOPTIMIZE=1.

Validation:20 numerical+9 page+12 archive contracts pass in the integrated source;20 numerical also pass core-only; scoped desktop Clippy -D warnings/formatting/native binary build pass. Strict95-path review/admission plus clean18-command native/rational and fresh packet26 normal/-O (zero skips) pass on b38c3fe (tree efe7b6b8afcae7ed531bd7601c37c6526d626aa9). Exact receipts /tmp/rheon-m3-values-qualified and /tmp/rheon-m3-values-packet; no stale receipts or gate weakening.

Actual integrated root-window interaction under software X11/llvmpipe opened an exact saved set and comparison page; selected pressure reference1..2/candidate1, yielding1 matched interval and1 unmatched reference; showed actual endpoint/dt/interval, Pa/common bounds/gauge; exported without overwrite; reopened as Unverified and verified exact sources. Temporarily hiding an owned test source produced Missing and removed stale metrics; bytes restored exactly; Close exit0. Independent SQLite/native-bit oracle checked the actual exported512-sample pressure metrics in all3 Python modes. Observation SHA25636e06591f177ed7b72ef9afd0b00c0f8a76bdda999c7086362701740601af550; result0febc3e9004856bab33c7abc946b5a19f3c79364d098ac382e0d1f256bf2d41d; binarye1e5306288bccb32f1437c3caec2847712419deb130730a38596ba4e8968ffdc. Generated material remains outside Git; no hardware GPU/build authenticity claim.

Linked native slice/probe rendering remains allocated to companion new files. Typed diagnostic storage is a separate stacked draft; runtime teacher/stop capture and actual trained bundle remain open. Keep draft pending those applicable scope/CI gates; no full M3 or physical/model qualification claimed. All merges/branch retirement stay serial; preserve companion #86/#89 and active stack.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 40822b77-ede6-4a63-a638-c530438ce8c6
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Jeremy added 3 commits October 15, 2026 19:20
…015' into implementation/configurable-native-m3-integration-20261015

# Conflicts:
#	docs/education/NATIVE_ADMISSION_INTEGRATION_REVIEW.md
#	docs/education/aligned-strain-native-sources-integration-20261014.json
#	docs/plans/configurable-solver-components/execution-ledger.md

Copy link
Copy Markdown
Owner Author

Acknowledged concrete allocation from #89 comments6200315546/6200446821. I missed it while watching #87; corrected now. Fetched exact integrated head b38c3fe1e58da4991673887dfb779c666f751f06, created isolated branch implementation/configurable-linked-native-view-20261015 in /workspace/rheon-linked. I own ONLY the three newly allocated comparison_field_view.rs, comparison_field_view_contract.rs, comparison-field-view.md; existing Page/core/root/runsets/admission files stay frozen/read-only. Actual public ComparedValues/native_samples + your overflow/oracle fixes will be preserved; no copy of earlier private numerical modules.

Concrete direction: cached linked2D native sample slice/probe, shared axis/index/probe and exact physical XYZ/nativeassociation/time/interval/unit/common finitebounds; pressuregauge diagnostic exactly declared. Explicit load of SelectedNativePair reopens pinned exact sources once, delegates actual values/geometry/sampling/reduction/gauge to compared_values, reads actual times from those same Selections. Cheap current-selection identity check on show clears stale/unverified cache; no perpaint database loads. Bounded preflight/native arrays/canvas workload; no remapping/zero replacement. Will report exactlead-callable API shortly for root registration, then freeze/review/test/publish newfile-only draft for your serialintegration.

Meanwhile #89 head06ccf43 full local desktop suite completed:636passed,0failed,5explicitmodel-environment ignored; all-targetdesktopClippy passed. Hosted checks are ongoing; Pages confirmedinventorygate. These results do not transfer to this new b38-based source or close requestedmodel/diagnostic acceptance.

Copy link
Copy Markdown
Owner Author

Allocated three-file field-view API is now concrete on implementation/configurable-linked-native-view-20261015, based exactly on b38c3fe:

  • ComparisonFieldView::default(), load(SelectedNativePair) -> Result<(), FieldViewError>, clear(), and show(ui, current: Option<SelectedNativePair>).
  • Root call should be view.show(ui, page.selected_pair()) AFTER the page controls update selection, giving same-frame invalidation on unverified/changed selection. The full-width controls need a bounded upper region or another layout that leaves actual canvas height; the current page controls should not be squeezed into a narrow column.
  • Explicit Load opens the two exact selections once through the existing store, calls the public numerical materializer once, and retains bounded native arrays. Paint performs no archive I/O or reductions. Actual per-side time/interval/stage metadata comes from those same selections.
  • Shared slice axis/index and probe, native cell/face association and physical coordinates, one common bound/units, explicit gauge offset. No averaging, remapping, NaN replacement, worker/store duplication, or source admission changes.
  • Preflight work/array/plane caps will be documented and tested, without an RSS claim. Source failures/unavailable results/selection changes clear cached scientific display. Cached paint labels the last successful validation; explicit Load revalidates external files.

Only the three allocated new files will change. Independent review, actual public-API tests, and a native interaction harness are pending before publication. Please retain root registration, admission inventory, and all merges under lead ownership.

Copy link
Copy Markdown
Owner Author

Allocated linked-view component is ready for your serial integration: draft PR93 #93, branch implementation/configurable-linked-native-view-20261015, exact head 76cc71af9f2750354924eda30313eb7dbacf8c46, clean worktree at /workspace/rheon-linked, stacked directly on exact b38c3fe. Only the three allocated new files changed; shared/root/recording/admission files untouched. No merge or branch cleanup performed.

Reviewed exact source SHA911b7095, tests6a0454a1, docs3e8f47cb. 67 focused desktop +20 core-only passed; independent reviewer reran9 contracts/Clippy/format and approved with no material findings. Actual frozen native harness using the public comparison library exercised cold Unverified→Verify→Load, linked slice/probe/time changes, pressure and mean-offset diagnostic, native X faces/X-Z normals, source-free cached painting, missing-source reload clearing, page Missing/stale-metric clearing, byte-exact restoration/recovery, Close exit0. Independent stdlib SQLite/native-bit oracle checked14 observed display states in normal/-O/PYTHONOPTIMIZE=1 and rejected a perturbed probe in all modes.

Evidence /tmp/rheon-linked-native-observation.json SHA256a8f04c1fc2c0fdd43a163a174e0dcd2e6288f2f38352127c50f7eac227da5c20. PR body links callable API/bounds and records artifact hashes/scope. Please register the component/page-first current-selection call in root, retain usable vertical space/scroll access, review the new source inventory, and run fresh integrated native/admission/CI evidence before any merge. Temporary harness evidence is not whole-product GUI/hardware/model acceptance. All merges remain yours.

Separately frozen PR89 head06cc now has hosted core-only and desktop feature jobs PASS on test mergece50aba; default feature job still running. Pages remains fail-closed on the already-reported four-path source inventory difference. No checks weakened or stale receipts reused.

Copy link
Copy Markdown
Owner Author

Final integration boundary: PR93's Pages build has now actually refused exact source76cc71af9f2750354924eda30313eb7dbacf8c46 with reviewed native source inventory added or missing path; I downloaded the job log and confirmed checkout. Read-only audit is95 reviewed→96 actual, exactly the new field-view source SHA911b7095, no changed/missing existing paths. No inventory/receipt/gate mutation. Other PR93 CI jobs are queued/running on test mergee916e4a0fba0ecb1467d6422581c71328b0ad74f; no green-PR claim.

PR89 frozen06cc all feature jobs now PASS (core-only492/3ignored, default499/3ignored, desktop636/5ignored; zero failures), along with previously reported executable/native/conditional/cloud/VTK/lessons/scoped jobs. Logs confirm actual test mergece50aba. Aggregate waits for its runner; Pages remains the independent source-inventory refusal already reported. No runtime/model qualification inferred.

All allocated implementation/review/native-harness work is delivered in PR93 and its observation manifest. Remaining source/root registration and fresh integrated native/admission/CI acceptance are yours under the explicit shared-owner allocation; all branches preserved and no merge attempted. Ready for your integration or specific reviewed follow-up on these owned files.

@MrScripty
MrScripty changed the base branch from implementation/configurable-native-m2-integration-20261015 to main October 15, 2026 20:31
@MrScripty
MrScripty marked this pull request as ready for review October 15, 2026 20:32
@MrScripty
MrScripty merged commit 42fa903 into main Oct 15, 2026
18 checks passed
@MrScripty
MrScripty deleted the implementation/configurable-native-m3-integration-20261015 branch October 16, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant