Skip to content

Link saved native comparisons with shared slice and probe - #93

Closed
MrScripty wants to merge 1 commit into
implementation/configurable-native-m3-integration-20261015from
implementation/configurable-linked-native-view-20261015
Closed

MrScripty wants to merge 1 commit into
implementation/configurable-native-m3-integration-20261015from
implementation/configurable-linked-native-view-20261015

Conversation

@MrScripty

@MrScripty MrScripty commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Saved native comparisons need a shared physical slice and probe while preserving their exact recorded evidence. Add a bounded two-pane sample view that explicitly reloads the two pinned selections through the existing run-set owner and public recording::comparison::compared_values, then paints cached native samples with one common range. Both panes share axis/index/probe, display actual per-side time/stage/interval and physical XYZ, and retain native cell/face association and pressure-gauge diagnostics.

Stacked on #91 at b38c3fe. Exactly the three new files allocated in the lead handoff change. No existing source, root registration, numerical reduction, renderer, worker/store, source inventory or admission receipt changes. Root integration and all merges remain lead-owned.

Call ComparisonFieldView::default() once and view.show(ui, page.selected_pair()) AFTER page controls update each frame. Only the explicit Load action opens sources or reduces fields. Changed/unverified/unavailable selections clear both panes immediately; failed reload clears this view's arrays. The page separately owns its last-checked metrics/status. Cache labels explicitly state last successful verification and no background source monitoring. Preflight source/publication/payload/sample/plane limits are documented; retained bytes are not RSS.

Validation on the exact frozen files now committed at 76cc71af9f2750354924eda30313eb7dbacf8c46:

  • 67 focused desktop contracts pass: 9 view, 20 numerical, 12 artifact, 9 page, 17 run-set. Core-only 20 pass. Scoped Clippy with warnings denied, formatting and whitespace checks pass.
  • Independent review approved exact view 911b7095, tests 6a0454a1, docs 3e8f47cb after fresh 9-contract/Clippy/format runs. The actual slice-edit regression is covered by keyboard events; both pane probes use actual egui pointer events. Real closed/pinned Jacobi/SGS archives exercise all six roles, gauge/sample geometry/time, failures and limits.
  • Actual native eframe harness on software X11/llvmpipe reopened a saved result Unverified→Verify→explicit Load; edited slice/probes in both panes and matched physical time; checked pressure/direct and nonzero mean-offset diagnostic, X-face dimensions/offsets and X/Z normals. Cached painting continued with an owned archive hidden; explicit reload cleared fields; page recomputation reported Missing and cleared metrics; archive restored byte-exact, reload recovered, Close exited 0.
  • Independently authored stdlib SQLite/IEEE oracle verified 14 actual displayed states (physical probe, native sample, units, per-side time/dt/stage/pressure interval, common bounds) in normal/-O/PYTHONOPTIMIZE=1 and rejected the deliberately perturbed probe at the intended check in all modes.

Executor evidence: /tmp/rheon-linked-field-view-freeze.json; /tmp/rheon-linked-native-observation.json SHA256 a8f04c1fc2c0fdd43a163a174e0dcd2e6288f2f38352127c50f7eac227da5c20. Harness binary SHA256 b73ac3d9c11f0df39709d4fc0889a338124f651ab0ac0c212d3045092e61a99f; source/log/oracle/screenshot hashes are in the observation manifest. Generated material is outside Git.

Keep draft pending lead root registration, fresh integrated native-window/source-admission evidence and applicable CI. The harness is not whole-product GUI acceptance, hardware GPU validation, build authenticity, trained-model parity or full generic M2–M3 acceptance. Typed teacher/stop capture and physically qualified accepted-provider composition remain separate gates. Preserve dependency branches until the stack no longer needs them.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Read-only source admission audit on exact head76cc71af9f2750354924eda30313eb7dbacf8c46:95 reviewed paths versus96 actual; only added path is src/bin/desktop/comparison_field_view.rs, exact SHA256 911b7095ccc2897d811b7946a5fabadc31703263879bec73d9b8f082573d1106. Zero existing source changes and zero missing paths. /tmp/rheon-pr93-native-inventory-audit.json; this is not qualification or an inventory refresh. The lead must review/record the integrated root+component source and rerun fresh admission/native/rational evidence. Current CI remains running/queued; no gate edits or receipt reuse.

Native verification finished with exact source hashes unchanged; owned Xvfb server was stopped after the harness closed with exit0 and no visible test windows remained. Both fixture source SHA256 values were rechecked after byte-exact restoration.

Copy link
Copy Markdown
Owner Author

Repository cleanup: closing this superseded scoped proposal. Its reviewed change is incorporated on main d8771ad83c30644d29929c96534548ce238bb357 through 90ee568b60ce9fefa4ad0455538caa6c0dc9b7b6, 133a9423c8e554ba8dce24b1f9b3c04e89ba2f3e. The linked cell/face slice/probe view, identity-bound cached loading, physical geometry/time/gauge and failure invalidation are present. Main extends its source adapter to configured saved sources; the original field-view API document remains byte-identical. Independent source/history review confirmed that the allocated product change is retained. The original branch is not classified as fully merged and is retained by this cleanup.

@MrScripty MrScripty closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant