Repository navigation
Link saved native comparisons with shared slice and probe - #93
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Read-only source admission audit on exact head76cc71af9f2750354924eda30313eb7dbacf8c46:95 reviewed paths versus96 actual; only added path is Native verification finished with exact source hashes unchanged; owned Xvfb server was stopped after the harness closed with exit0 and no visible test windows remained. Both fixture source SHA256 values were rechecked after byte-exact restoration. |
|
Repository cleanup: closing this superseded scoped proposal. Its reviewed change is incorporated on main |
Saved native comparisons need a shared physical slice and probe while preserving their exact recorded evidence. Add a bounded two-pane sample view that explicitly reloads the two pinned selections through the existing run-set owner and public
recording::comparison::compared_values, then paints cached native samples with one common range. Both panes share axis/index/probe, display actual per-side time/stage/interval and physical XYZ, and retain native cell/face association and pressure-gauge diagnostics.Stacked on #91 at b38c3fe. Exactly the three new files allocated in the lead handoff change. No existing source, root registration, numerical reduction, renderer, worker/store, source inventory or admission receipt changes. Root integration and all merges remain lead-owned.
Call
ComparisonFieldView::default()once andview.show(ui, page.selected_pair())AFTER page controls update each frame. Only the explicit Load action opens sources or reduces fields. Changed/unverified/unavailable selections clear both panes immediately; failed reload clears this view's arrays. The page separately owns its last-checked metrics/status. Cache labels explicitly state last successful verification and no background source monitoring. Preflight source/publication/payload/sample/plane limits are documented; retained bytes are not RSS.Validation on the exact frozen files now committed at
76cc71af9f2750354924eda30313eb7dbacf8c46:911b7095, tests6a0454a1, docs3e8f47cbafter fresh 9-contract/Clippy/format runs. The actual slice-edit regression is covered by keyboard events; both pane probes use actual egui pointer events. Real closed/pinned Jacobi/SGS archives exercise all six roles, gauge/sample geometry/time, failures and limits.Executor evidence:
/tmp/rheon-linked-field-view-freeze.json;/tmp/rheon-linked-native-observation.jsonSHA256a8f04c1fc2c0fdd43a163a174e0dcd2e6288f2f38352127c50f7eac227da5c20. Harness binary SHA256b73ac3d9c11f0df39709d4fc0889a338124f651ab0ac0c212d3045092e61a99f; source/log/oracle/screenshot hashes are in the observation manifest. Generated material is outside Git.Keep draft pending lead root registration, fresh integrated native-window/source-admission evidence and applicable CI. The harness is not whole-product GUI acceptance, hardware GPU validation, build authenticity, trained-model parity or full generic M2–M3 acceptance. Typed teacher/stop capture and physically qualified accepted-provider composition remain separate gates. Preserve dependency branches until the stack no longer needs them.