feat(recording): retain typed diagnostic attempts outside accepted archives

[MrScripty]

Diagnostic model attempts need durable physical requests and honest failed outcomes without becoming accepted simulation publications. Add typed, bounded SQLite diagnostic archives under the existing recording owner, plus explicit accepted-reader archive-kind rejection on open and subsequent operations. This draft stacks on #91.

The new contract stores immutable run/binding/domain/native-prefix declarations, RHS/prior/host residual, contiguous attempt indices, candidate or closed no-candidate reasons, versioned host qualification observations, equal-request native reference, actual history transition and terminal recorded/unrecorded-prefix facts. Separate RHDP application identity and typed tables preserve accepted archive-v1 semantics. Cold selection executes no model; hashes prove consistency rather than authenticity or physical correctness. No dependency, solver, engine, worker or model-process change.

Independent GPT-6.1 Sol High review closed three material findings: bit-exact domain matching prevents signed-zero append/cold-reopen disagreement; rejected seeds cannot initialize stop/teacher mode and teacher seed is explicitly observed Accepted; checked chronology rejects impossible unrecorded-tail generation claims. Native teacher fixtures retain actual Accepted priors and unchanged native evolution despite biased rejected candidate observations. Kind/header mutation, tamper, resource, partial-prefix, poison, cancellation and no-overwrite regressions are included.

Final serial-owner validation on f56a756 (tree f2d38604329906ed1133f152214ee1e80ac04476): strict 96-path admission/review; clean native/rational qualification (18 commands, Lean unchecked); fresh packet 26 tests normally and under -O, zero skips; 17 diagnostic +15 accepted recording +4 carrier +20 native-comparison tests (56 total); scoped core Clippy with warnings denied and formatting passed. Exact evidence: /tmp/rheon-diagnostic-owner-qualified and /tmp/rheon-diagnostic-owner-packet. Subsequent documentation-only follow-through binds native-window observations and handoff; no receipt is transferred to another tree.

This is partial diagnostic storage only. Existing Engine/ModelProcess/worker attempt capture, teacher/stop policy execution and record-before-UI wiring, saved diagnostic run-set membership, linked slice/probe display and actual trained bundle remain separate gates. It does not complete A6 or M1–M3 acceptance. Keep draft; no implementation PR is merged and branch retirement remains blocked by active dependents. Canonical plan/ledger and docs/api/diagnostic-recording.md preserve scope and evidence.

Integration disposition: the reviewed storage ancestor f7d9515 is retained in #95, which upgrades its typed runtime/schema to2 and includes end-to-end teacher/stop capture, frozen reruns, cold inspection and fresh combined-source/native qualification. Keep this partial-storage draft/source branch until that complete rollup lands; do not force an intermediate schema1 main release or relabel its original scoped receipts.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}