Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports the receive routing and notification encoding, with no unresolved blocking issues identified.
No open issues 🎉
What changed in this PR
Adds direct reception of Zigbee Green Power frames and forwards their unprocessed payloads and receive metadata to zigpy through the existing notification protocol. Transmission remains future work.
Changes:
- Adds Green Power frame-control parsing with a unit test.
- Routes received Green Power frames into driver notifications and wire-protocol messages.
- Documents receive support and the timing constraints for future transmission support.
| File | Description |
|---|---|
| README.md | Documents Green Power reception and remaining transmission work. |
| crates/ziggurat-zigbee/src/lib.rs | Exports the Green Power module. |
| crates/ziggurat-zigbee/src/gp.rs | Defines and tests Green Power frame-control parsing. |
| crates/ziggurat-zigbee/src/constants.rs | Adds the Green Power protocol-version constant. |
| crates/ziggurat-protocol/src/wire.rs | Defines and serializes Green Power receive notifications. |
| crates/ziggurat-protocol/src/bridge.rs | Converts driver notifications into wire payloads. |
| crates/ziggurat-driver/src/zigbee_stack/mac.rs | Detects, filters, and forwards received Green Power frames. |
| crates/ziggurat-driver/src/zigbee_stack.rs | Adds the Green Power receive notification variant. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Receiving ZGP frames is very straightforward and they will be passed straight to zigpy.
Sending ZGP frames is another problem and is future work.