Repository navigation
Support ReceivedGpdf command - #11
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 1185 1248 +63
=========================================
+ Hits 1185 1248 +63 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The receive path matches the server protocol and zigpy interfaces, with focused tests and no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds Green Power frame reception to the Ziggurat adapter, forwarding packets to zigpy for processing. This depends on the server support in zigpy/ziggurat#69.
Changes:
- Defines and registers the
ReceivedGpdfnotification. - Parses received frames and supplies the MAC sequence number when no security frame counter is present.
- Adds receive-path tests and requires zigpy 2.4.0 or newer.
| File | Description |
|---|---|
zigpy_ziggurat/zigbee/wire.py |
Defines the notification ID and wire payload. |
zigpy_ziggurat/zigbee/protocol.py |
Registers the notification and exposes its optional source address. |
zigpy_ziggurat/zigbee/application.py |
Forwards Green Power packets and guards Zigbee-only device handling. |
uv.lock |
Updates locked zigpy and aiosqlite dependencies. |
tests/test_application.py |
Covers Green Power reception and updates coordinator type handling. |
pyproject.toml |
Requires zigpy 2.4.0 or newer. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Receive and pass through Green Power frames to zigpy.
Unlike zigpy-deconz (which is mostly raw but strips headers), we don't process much with Ziggurat so it's a simple passthrough.
Requires zigpy/ziggurat#69.