Repository navigation
feat(diagnostics): add source spans to W0401 warnings - #128
Merged
Merged
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 30, 2026
tmlmt
changed the base branch from
fix/cookware-quantities-logic
to
graphite-base/128
October 30, 2026 19:51
tmlmt
force-pushed
the
feat/span-w0401
branch
from
October 30, 2026 19:53
2c33243 to
d277627
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds source locations to W0401 warnings when text and numeric quantities cannot be combined, so diagnostics can point to the relevant recipe mention. No dependencies are required.
Related Issue:
Type of change
Breaking Changes
None.
How Has This Been Tested?
On the combined branch:
pnpm test— passed (1,048 tests)pnpm lint— passed (one existing warning in the VitePress config)