Skip to content

fix!: apply the same logic for cookware quantities as for ingredients - #127

Merged
tmlmt merged 1 commit into
v3from
fix/cookware-quantities-logic
Oct 30, 2026
Merged

tmlmt merged 1 commit into
v3from
fix/cookware-quantities-logic

Conversation

@tmlmt

@tmlmt tmlmt commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Description

Aligns cookware quantity aggregation and variant handling with ingredient behavior. Cookware now exposes quantities (an array) instead of quantity (a single value). The cookware reference mismatch diagnostic is also revised. No dependencies are required.

Related Issue:

  • N/A

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Breaking Changes

  • Diagnostic: COOKLANG_E0203 is repurposed to the Cookware equivalent of COOKLANG_E0204
  • Migration: Cooklang now has aquantities array instead of a single-valuequantity
  • New behavior: Cookware quantities are aggregated across mentions, with variant handling aligned to ingredients.

How Has This Been Tested?

On the combined branch:

  • pnpm test — passed (1,048 tests)
  • pnpm lint — passed (one existing warning in the VitePress config)

tmlmt commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner Author

tmlmt commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner Author

Merge activity

  • Oct 30, 7:50 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 30, 7:52 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 30, 7:52 PM UTC: @tmlmt merged this pull request with Graphite.

@tmlmt
tmlmt changed the base branch from fix/ingredient-ref to graphite-base/127 October 30, 2026 19:50
@tmlmt
tmlmt changed the base branch from graphite-base/127 to v3 October 30, 2026 19:50
BREAKING CHANGE:
- COOKLANG_E0203 is renamed and repurposed
- Cookware now has a `quantities` property (array) replacing the previous `quantity` (single-value)
@tmlmt
tmlmt force-pushed the fix/cookware-quantities-logic branch from 3fa629e to e70346f Compare October 30, 2026 19:51
@tmlmt
tmlmt merged commit 2c6766a into v3 Oct 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant