Repository navigation
chore(release): 2.0.0 - #303
Conversation
Major version: Sprout recovery was removed (#301), and supported recovery moved to the NU7 SDK (#302). The funded NU7 rehearsal that the qualification doc lists as a release gate has not been run. This release waives it by maintainer decision, and the qualification doc now records the waiver rather than a pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
poldsam
left a comment
There was a problem hiding this comment.
Post-merge review. The release run for v2.0.0 (42301740757) is already approved and signing.
The version bumps are consistent: workspace Cargo.toml, the workspace crates in Cargo.lock, and tauri.conf.json all say 2.0.0. The fuzz lockfile is deliberately left behind, as the description explains.
Two things about what 2.0.0 ships, not about this diff:
- #302 (+7,634/−733) has no human review on GitHub. The only review on it is the code-scanning bot. This description cites "the #302 review" for its known gaps, but that review isn't on the PR. Since #302 is most of the code in 2.0.0, it would help to post that review there, or add a post-merge one, so the release has a record of what was checked.
- Combined with the waived rehearsal, nothing in 2.0.0 has been observed spending on an NU7 chain. The one feature the release keeps (supported recovery on the NU7 SDK) has never produced a mined transaction under the new SDK, on regtest or anywhere else. The waiver records that honestly. It would be worth stating it in the release notes too, and running the funded rehearsal before anyone is pointed at 2.0.0 with real funds.
| NU7 sweep or imported-Sapling PCZT transaction has been observed mined for | ||
| this release. The evidence behind 2.0.0 is the offline and fast-profile layers | ||
| above, plus the unit and proposal tests listed below. The rehearsal stays the | ||
| outstanding qualification item for supported recovery after NU7. |
There was a problem hiding this comment.
The waiver ends up glued to the next line, No release, real-wallet funding or mainnet spending is authorized here. There's no blank line between them, so it renders as one paragraph that waives the gate for a release and then says no release is authorized. Suggest a blank line before it and a reword, e.g. "Apart from the 2.0.0 waiver above, no release, real-wallet funding or mainnet spending is authorized by this document."
Release 2.0.0
Changes in this PR
Cargo.toml,Cargo.lock(workspace crates only) andgui/src-tauri/tauri.conf.json.docs/qualification/nu7-supported-recovery.mdrecords that the funded NU7 rehearsal gate is waived, not passed, for 2.0.0, by maintainer decision.crates/argos-wallet-import/fuzz/Cargo.lockis left alone. It is behind #302's SDK upgrade, and refreshing it would pull in hundreds of lines of unrelated dependency changes. That's for a separate PR.Known gaps carried into 2.0.0 (from the #302 review)
🤖 Generated with Claude Code