Repository navigation
Conversation
ZIP 218's shielded limits are per block. Batches of 298 notes filled a block's whole Sapling budget, so they could only be mined in a block with no other Sapling activity and risked expiring unmined. Batches now target 80 notes (about a quarter of the block budget), falling back to fewer, larger batches only when the wallet cannot pay the extra output padding. A proposal that already fits a block but cannot be split is kept as one transaction. Also: - Accept tips timestamped up to 30 minutes ahead (miner skew or a slow local clock), and say which check failed and that the clock may be the cause. - GUI: say when a stale birthday estimate is discarded instead of leaving "Looking up block height..." on screen. - Qualification doc: separate the 2.0.0 waiver from the sentence that no release is authorized. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the post-merge reviews of #302 and #303 (#302 review, #303 review). Intended for 2.0.1, or for 2.0.0 if the draft is re-cut.
Batches fill a whole block's shielded budget
ZIP 218's limits are per block: "The total number of Sapling inputs and outputs across all transactions in the block MUST NOT exceed 300", and likewise the global budget of 330.
bound_send_maxsized batches at 298 notes + 2 outputs, so each one used the block's entire Sapling budget. A batch like that can only be mined in a block with no other Sapling activity, and under real shielded traffic it risks sitting in the mempool until its 120-block expiry.RECOVERY_BATCH_NOTES = 80notes. With padding that is at most 82 of 300 Sapling components and 86 of 330 overall.batching_distributes_value_to_pay_cross_pool_output_paddingstill exercises this path).unsplittable_proposal_that_fits_a_block_is_kept).Tip timestamp tolerance
validate_tip_evidencerefused any tip timestamped more than 5 minutes ahead of the local clock. That rejects legitimate tips from miners whose timestamps run ahead, and any computer whose clock runs a few minutes slow. The future bound is now 30 minutes. Freshness is still enforced byMAX_TIP_AGE. The two failures now have separate messages, and both name the system clock as a possible cause. A test covers a tip 10 minutes ahead being accepted.Smaller fixes
docs/qualification/nu7-supported-recovery.md: the 2.0.0 waiver ran into "No release … is authorized here". It is now its own paragraph, and the last sentence reads "Apart from the 2.0.0 waiver above, …".Not in this PR
The funded NU7 rehearsal is still outstanding.
regtest_local_networkkeepsnu7: None, so no sweep has been mined under NU7 rules, including one at the new batch size.Tests
cargo test -p argos-core --lib --locked: 692 passed, 0 failed.cargo clippy --workspace --all-targets --all-features --locked -- -D warnings: clean.cargo fmt --all: clean.node --test tests/gui/: 189 passed.🤖 Generated with Claude Code