refactor(emcn): share Code.Viewer appearances by BillLeoutsakosvl346 · Pull Request #8238 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T18:36:36Z

Summary

Add inspection and flat appearances to the shared EMCN Code.Viewer, including its virtualized path.
Move repeated viewer chrome from logs, preview, terminal, deployment and hover-card callers into those appearances. Remove exact default classes at the callers.
Preserve the existing rendered geometry and colours; marketing code is outside this PR.

Base and design review

Targets codex/control-fix-workflow-preview-actions (#8065), whose current head was verified as 319f8bb before publication. The local design diff check reports 11 central-definition items for the intentional new EMCN appearance recipe and no new caller styling violations. These system changes reproduce the previous caller classes; they are retained in the raw report for review.

Validation

Focused EMCN tests, EMCN and workflow-renderer type checks, app type check, Biome, and git diff --check passed.
Matched before/after source-derived captures in light/dark at 16px and 20px root text, including copied states, have identical content pixels and computed styles. Evidence is stored outside the product checkout.
Frozen scanner 2.9.7 on the exact improvement(ui): share workflow preview actions #8065 base/head found 1,106 → 1,070 raw styling findings: 36 fewer component-chrome occurrences, zero new normalized violations, unchanged advisories/unchecked diagnostics, and zero coverage failures. The comparison report is external to this PR.
Greptile is 5/5 and Cubic reviewed this head; checks passed and threads are resolved. The dependent parent stack still needs ancestry refresh before merge. This PR remains unmerged.

Visual comparison

Representative matched captures from the local source-derived fixture. Before uses this PR’s base; after uses this PR’s head. Full light/dark and root-size matrices are retained outside the product branch.

Light · 16px root text · default

Before	After

Dark · 20px root text · default

Before	After

BillLeoutsakosvl346 · 2026-09-24T18:36:43Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T18:36:44Z

@cubic-dev-ai review this PR

vercel · 2026-09-24T18:36:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 24, 2026 6:46pm UTC

cubic-dev-ai · 2026-09-24T18:36:50Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-24T18:41:10Z

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed changes.

Summary

The PR moves repeated Code.Viewer container styling into shared inspection and flat appearances, applies them across workspace and workflow-renderer callers, and adds appearance tests. The change since the previous review adds coverage for the virtualized flat terminal path.

_{Reviews (2) · Last reviewed commit: "Test flat virtualized Code.Viewer termin..."}

BillLeoutsakosvl346 · 2026-09-24T18:43:59Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T18:44:00Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T18:44:07Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

* improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

Add shared Code.Viewer appearances for product surfaces

03c23d5

vercel Bot deployed to Preview September 24, 2026 18:39 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread packages/emcn/src/components/code/code.test.tsx

Test flat virtualized Code.Viewer terminal chrome

dffc482

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

vercel Bot deployed to Preview September 24, 2026 18:46 View deployment

BillLeoutsakosvl346 mentioned this pull request Sep 24, 2026

Share code search overlay across product viewers #8266

Merged

BillLeoutsakosvl346 merged commit 9d5746a into codex/control-fix-workflow-preview-actions Sep 24, 2026
8 checks passed

BillLeoutsakosvl346 mentioned this pull request Sep 24, 2026

Carry code search overlay into the live EMCN stack #8275

Open

Navigation Menu

refactor(emcn): share Code.Viewer appearances - #8238

refactor(emcn): share Code.Viewer appearances#8238
BillLeoutsakosvl346 merged 2 commits into
codex/control-fix-workflow-preview-actionsfrom
codex/emcn-next-code-viewer

BillLeoutsakosvl346 commented Sep 24, 2026 •

edited

Loading

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

vercel Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Base and design review

Validation

Visual comparison

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillLeoutsakosvl346 commented Sep 24, 2026 •

edited

Loading

vercel Bot commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading