Share code search overlay across product viewers by BillLeoutsakosvl346 · Pull Request #8266 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T20:09:29Z

Summary

Share the code search overlay across workflow preview, log details, trace view, and terminal output.
Keep each caller's search state, placement, input kind, tally wording and actions. The shared feature component reuses EMCN Button, Input and ChipInput.
Preserve the terminal's attached 4px lower radius as an intentional Extra. Moving the class into the shared component changes its source location, not its rendered shape; the raw design finding remains visible.

Base and design review

Targets the exact Code.Viewer #8238 head dffc482e. This component builds on that branch's viewer appearances; the PR is intentionally separate from other EMCN migrations.

The local 3.10.7 design diff completed with three raw findings, all from existing classes moved into the shared component: the terminal's rounded-b-[4px] lower edge and the plain search Input's h-[23px] and text-caption overrides. The radius has a uniquely fingerprinted retained-Extra decision in the external review ledger. The two Input overrides remain unresolved owned-chrome findings for a separate EMCN compact Input treatment; they have not been classified as Extras or suppressed. One advisory records the existing shadow-xs shell treatment now shared by this feature. There are no coverage failures.

Validation

Focused overlay tests pass (3/3), covering query, navigation, close, disabled actions, event isolation and terminal markers. Biome passes on all six changed files.
Matched source-derived captures cover all four surfaces in light and dark at 16px and 20px root text, with idle, input focus, button focus and empty-result states. All 16 before/after image pairs are pixel-identical; computed styles and geometry match. Enter and Space each activate the focused Next button once.
Review images, computed values and the retained-Extra decision are stored outside this product PR in the local design review directory.
App-wide type checking and full base/head scanning remain pending in the coordinator's serial validation queue. This is a draft until those checks and current-head Greptile/Cubic review pass.

vercel · 2026-09-24T20:09:35Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 8:09pm UTC

BillLeoutsakosvl346 · 2026-09-24T20:09:41Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T20:09:46Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T20:09:50Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-24T20:13:35Z

Confidence Score: 4/5

The PR is not ready to merge because the outstanding repository requirement to use ChipInput in the shared overlay remains unmet.

Findings

Legacy input in shared overlay ▶

Summary

The PR extracts the code-search controls into a shared overlay while leaving search state with each viewer.

Workflow preview, log details, trace view, and terminal output now render the shared component.
The component retains caller-specific placement, input kind, result wording, and terminal styling.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Preview[Workflow preview] --> Overlay[CodeSearchOverlay]
  Logs[Log details] --> Overlay
  Trace[Trace view] --> Overlay
  Terminal[Terminal output] --> Overlay
  Overlay --> Actions[Caller-owned search state and actions]

_{Reviews (3) · Last reviewed commit: "refactor(ui): share code search overlay ..."}

greptile-apps · 2026-09-24T20:13:39Z

+        <ChipInput {...inputProps} className='mr-0.5 w-[94px]' />
+      ) : (
+        <Input {...inputProps} className='mr-0.5 h-[23px] w-[94px] text-caption' />
+      )}


Legacy input in shared overlay

The new plain-input branch uses Input for preview and terminal search. The repository’s EMCN directive requires new shared controls to use ChipInput instead of the legacy Input. Preserve the intended compact appearance, but satisfy that requirement before merging.

Context Used: EMCN component library patterns with CVA (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Addressed in 81a8c60: the preview and terminal branches now use ChipInput with an EMCN-owned compactSearch appearance. The default 30px ChipInput remains unchanged; the compact appearance owns the existing 23px geometry and caption text. The source-derived fixture still has pixel-identical before/after captures in all 16 light/dark, 16px/20px, idle/focus/empty states. Focused overlay and EMCN tests pass.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T22:22:24Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T22:22:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:22:34Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

refactor(ui): share code search overlay controls

eab049f

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 marked this pull request as ready for review September 24, 2026 22:12

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit 31a8431 into codex/emcn-next-code-viewer Sep 24, 2026
5 checks passed

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 mentioned this pull request Sep 24, 2026

Carry code search overlay into the live EMCN stack #8275

Merged

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Base and design review

Validation

Uh oh!

vercel Bot commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

greptile-apps Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillLeoutsakosvl346 commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading