Make oauth.token_endpoint optional - #27
Merged
Merged
Conversation
The spec currently marks token_endpoint as REQUIRED, but that is being corrected. The parser still requires the oauth object and only checks token_endpoint is a string when it is present. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 29, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuthMetadata.token_endpointis now optional in the type.parseX401Payloadstill requires theoauthobject but only checkstoken_endpointis a string when it is present.token_endpoint, rejection of a non-stringtoken_endpoint, rejection of a missingoauthobject.spec/conformance.mdand the README to reflect the new behavior.The spec (v0.2.0) currently marks
token_endpointas REQUIRED. That is a spec error and will be corrected. The pinned spec artifacts (spec/fixtures/request.schema.json,spec/normative-ledger.json) are verbatim copies of the published spec and are left untouched; they will be re-synced once the spec is updated.Test plan
yarn check-allpasses (format, lint, typecheck, 38 tests, publint).🤖 Generated with Claude Code