Make the oauth object optional - #29
Merged
Merged
Conversation
The spec marks oauth as REQUIRED, but that is being corrected. The whole oauth object is now optional in the payload type, the parser, and buildPayload. When oauth is present, token_endpoint is required again. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #27, which only made
token_endpointoptional. The intended behavior is:oauthobject is optional onX401Payloadand on thebuildPayloadinput.buildPayloadomits the key when it is not supplied.oauthis present,token_endpointis required (a string).OAuthMetadata.token_endpointis back tostring.parseX401Payloadskips theoauthcheck when the key is absent, and rejects a non-objectoauthor anoauthwithout a stringtoken_endpoint.Tests updated: a round-trip without
oauth, rejection ofoauthwithouttoken_endpoint, rejection of a non-stringtoken_endpoint, rejection of a non-objectoauth.spec/conformance.mdand the README reflect the new behavior.The spec (v0.2.0) still marks
oauthas REQUIRED; that is being corrected. The pinned spec artifacts underspec/fixturesandspec/normative-ledger.jsonare verbatim copies of the published spec and are left untouched until the next sync.Test plan
yarn check-allpasses (format, lint, typecheck, 39 tests, publint).🤖 Generated with Claude Code