Skip to content

Fix config test isolation on release runners - #352

Merged
patchstackdave merged 1 commit into
mainfrom
codex/publish-environment-test-isolation
Oct 2, 2026
Merged

patchstackdave merged 1 commit into
mainfrom
codex/publish-environment-test-isolation

Conversation

@patchstackdave

Copy link
Copy Markdown
Contributor

Summary

Fix the config test that passes in pull-request CI but fails on main-branch and release runners.

The fixture inherited GitHub hosting signals. A committed sandbox label intentionally does not override a production platform build, so the release runner correctly resolved production while the test expected sandbox.

  • Give config fixtures an isolated environment and explicit hosting signals.
  • Add 18 regression cases covering main-branch dispatch/push, tag releases, feature branches, pull requests, and pull-request-target events.
  • Verify committed local/sandbox labels, process overrides, provenance, and unchanged config files.
  • No runtime behavior changes, skipped assertions, or weakened publish gates.

Validation

  • Reproduced the original failure with GitHub main-branch workflow-dispatch variables.
  • Config/environment tests passed under those variables; config tests also passed under tag-release variables.
  • Full suite under the main-branch release environment: 4,276 passed, 7 skipped.
  • Typecheck (10 templates), build, mandatory security canary (7 tests), and npm pack dry-run passed.
  • Public-boundary review completed; fixtures use synthetic values.

Release follow-up

Existing release tags are unchanged. Publish from a new tag containing this fix after merge; rerunning the original v0.5.29 tag retains its failing test. No package has been published by this change.

@coderbuds

coderbuds Bot commented Oct 2, 2026

Copy link
Copy Markdown

Tests now fully isolate environment variables with cleaner setup.

🎯 Quality: 94% Elite · 📦 Size: Small

📈 This month: Your 205th PR — above team average · Averaging Excellent

See how your team is trending →

@patchstackdave

Copy link
Copy Markdown
Contributor Author

/review

@patchstackdave
patchstackdave merged commit 2e6ec4d into main Oct 2, 2026
23 checks passed
@patchstackdave
patchstackdave deleted the codex/publish-environment-test-isolation branch October 2, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants