Repository navigation
Add Color by provider tray icon style - #895
Merged
Merged
Conversation
added 5 commits
October 16, 2026 09:32
Add tinted variants of the bar, stacked, and percent renderers that take an optional provider accent. Pace colors win over the accent, error icons ignore it, and an accent below a 2:1 contrast floor against the tray canvas falls back to the usage-level colors. Existing renderers delegate with no tint, so default output is unchanged.
Store the opt-in Color by provider flag (default off) in settings and the raw serde mirror, and allow it in the portable preferences document so exports and imports carry it.
Add the opt-in tint to the tray plan: a single meter or percent glyph takes the shown provider's effective accent, and each stacked row takes its own provider's accent. The accent is parsed from #RRGGBB and malformed values yield no tint. Expose menu_bar_color_by_provider through the settings patch and the bridge DTO, with tests for default-off parity, accent overrides, and stacked rows.
Add the Color by provider switch below the pace toggle, wired to menuBarColorByProvider in the bridge types, with test fixtures and tests for the set call and the stacked-mode state. Add its label and helper strings to all ten locales, with keys in the Rust and TypeScript lists.
Add one Windows Unreleased line for the tray color-by-provider option, citing upstream steipete#4321.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Ui Changes Include Windows Proof |  |
The PR changes visible behavior. The diff adds a “Color by provider” toggle in MenuBarTab.tsx and provider-tinted tray rendering in rust/src/tray/render.rs. The description says “UI proof is pendi… |
Add screenshots or a completed proof note from a fresh Windows build to the PR description. Replace the pending UI-proof statement with the actual verification details. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Provider Data Stays Siloed The change keeps provider data siloed. provider_tintderives the tint from the sameProviderUsageSnapshot.provider_idand looks up that provider's effective accent. Stacked icons pass each selecte…Secrets Handled Safely No changed code or files introduce, log, display, snapshot, or persist a token, cookie, API key, OAuth credential, or authorization header. The new data path handles only a boolean setting, provider I… No Unapproved Dependencies The pull-request diff changes no Cargo.toml, package.json, npm/yarn lockfile, or pnpm packageManager declaration. It adds no dependency and does not change the pinned pnpm version. Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title is a short imperative summary that directly describes the addition of the Color by provider tray icon setting.
Full details: Ui Changes Include Windows Proof
-
Explanation
The PR changes visible behavior. The diff adds a “Color by provider” toggle in
MenuBarTab.tsxand provider-tinted tray rendering inrust/src/tray/render.rs. The description says “UI proof is pending” and that it “will be captured before merge”; it includes no screenshot or completed proof note from a fresh Windows build.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports upstream "Color by provider" (steipete#4321; upstream commits 2f232d6, fd7fab6, cad61e8, bb64180).
menu_bar_color_by_provider, default off, also allowed in the portable preferences document).effective_accent_color, so per-provider accent overrides apply.*_tintedvariants. The existing functions call them with no tint, so default output is unchanged.Differences from upstream:
Commands run
cargo fmt --all: cleancargo test --manifest-path rust/Cargo.toml: 4734 passed, 1 ignored. Two unrelated tests failed only under full-suite load and passed when run alone (dashboard::coordinatortimeout,grok::accounts::orcafile replace).cargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml: 741 passedcargo clippy -D warningson both manifests: cleanpnpm test: 135 files, 1272 tests passed;pnpm run build: ok (includes locale key check)UI proof
Result: pass, with one gap (tray icon pixels not captured).
feat/color-by-providerat 567f4faC:\Users\FSOS\AppData\Local\Win-CodexBar\cargo-target\repo-bb654619ec0c47e2\worktree-8e72f6650188b478\debug\codexbar-desktop-tauri.exe(built after HEAD)settings:menuBar; CDP port 9371pnpm run tauri:build:debug; launched withCODEXBAR_PROOF_MODEandWEBVIEW2_ADDITIONAL_BROWSER_ARGUMENTS=--remote-debugging-port. CDP drives the Settings page target (trustedInput.dispatchMouseEvent; native<select>set through the React value setter +change) and reads persisted values withget_settings_snapshot. cua-driver 0.34.0 givesverify_state, real-pixelget_window_statescreenshots and DWM facts. Background only: windows parked on the secondary monitor, no foreground or keyboard use. Settings were backed up and byte-restored afterwards.CDP assertions (all passed; log
W:/mac-parity/proof/895/steps.jsonl):menuBarColorByProvider(false at start).get_settings_snapshot().menuBarColorByProvideris true.CUA (
W:/mac-parity/proof/895/):verify_statewindow exists; DWM dark = true under themeauto.01-menubar-before.png,02-menubar-toggled.png,03-menubar-restored.pngNot covered:
SystemTray.NormalButton), but the captured rectangle showed no rendered icon. So the coloured tray icon itself is not proven. Unit tests cover the renderer only.Personal info visible: none in the screenshots. The tray tooltip read during the UIA attempt contains provider status text only.