Skip to content

fix: previews block so branch builds deploy #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorelljames merged 2 commits into from
Oct 28, 2026
Merged

fix: previews block so branch builds deploy #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff83ce
fix(website): add the previews block for branch builds
dorelljames Oct 28, 2026
377c8f5
fix(website): let wrangler build the site before deploying
dorelljames Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ Every change, from a person or an AI agent, follows the same path:
| Setting | Value |
|---|---|
| Root directory | repo root |
| Build command | `pnpm install --frozen-lockfile && pnpm test && pnpm --filter website build` |
| Build command | optional: `apps/website/wrangler.jsonc` has a `build.command` that installs, builds the site and runs the post-build checks before every deploy and preview |
| Deploy command | `pnpm --filter website exec wrangler deploy` |
| Other branches | `pnpm --filter website exec wrangler versions upload` (a preview URL per branch) |
| Other branches | `npx wrangler preview` (Cloudflare's default; gives each branch a preview URL, and needs the `previews` block in `wrangler.jsonc`) |

Node comes from `.nvmrc` and pnpm from `packageManager` in `package.json`. A failing test or post-build check stops the deploy.

Expand Down
10 changes: 9 additions & 1 deletion apps/website/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
"main": "worker/index.ts",
"compatibility_date": "2026-10-28",
"workers_dev": true,
// Wrangler builds the site before every deploy and preview, so CI needs no separate build step.
// `pnpm install` is a no-op when dependencies are already installed.
"build": {
"command": "pnpm install --frozen-lockfile && pnpm run build"
},
// Static assets are served first; the Worker only runs when no asset matches.
"assets": {
"directory": "./dist",
Expand All @@ -12,5 +17,8 @@
},
// www.jscebu.org is attached as a Workers Custom Domain (Cloudflare manages its DNS
// record and certificate). The apex jscebu.org still redirects to www via Vercel.
"routes": [{ "pattern": "www.jscebu.org", "custom_domain": true }]
"routes": [{ "pattern": "www.jscebu.org", "custom_domain": true }],
// Required by `wrangler preview`, which Workers Builds runs for non-production branches.
// Empty: previews reuse the top-level assets and compatibility settings, and get no routes.
"previews": {}
}
Loading