Repository navigation
fix: previews block so branch builds deploy - #12
Merged
Merged
Conversation
Workers Builds runs `npx wrangler preview` for non-production branches, and wrangler refuses without a `previews` block. An empty block is enough: previews reuse the top-level assets and compatibility settings, and production deploys are unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-workers-previews-jscebu-org.dorelljames.workers.dev (commit 377c8f5)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Branch builds failed because apps/website/dist did not exist when wrangler ran: the dashboard build step wasn't producing it. wrangler.jsonc now has a build.command (install, build, post-build checks), so every deploy and preview builds itself regardless of dashboard settings. Verified locally from a deleted dist/ with wrangler preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch builds on Workers Builds failed with: "Your Wrangler configuration is missing a
previewsblock". The non-production command isnpx wrangler preview."previews": {}toapps/website/wrangler.jsonc. Previews reuse the top-levelassetsand compatibility settings, and productionwrangler deploy(with the www Custom Domain) is unchanged.wrangler deploy --dry-runpasses.Once this merges, PR branches (including #10 and #11, after they're updated from main) get working preview builds.