Skip to content

fix: harden recovery evidence boundaries - #13

Merged
futuretyler merged 1 commit into
mainfrom
salvage/recovery-hardening
Jun 28, 2026
Merged

futuretyler merged 1 commit into
mainfrom
salvage/recovery-hardening

Conversation

@futuretyler

Copy link
Copy Markdown
Owner

Summary

  • validate run IDs as safe ledger path components and reject symlinked ledger run roots/directories
  • include file and directory symlink targets in effect snapshots so write-through changes are attributed
  • constrain run-trace contract reads to regular workdir-relative files
  • fail closed when effect observation is unknown after crashes or observer failures
  • recover started-only journal slots as interrupted + unknown effects instead of re-entering the same attempt
  • project explicitly unobserved effects as unknown evidence for trust status

Verification

  • npm run verify
  • Focused recovery fix review: no blocking issues after fixing unknown-effects retry ordering and directory-symlink attribution.

Review notes

  • P3 ponytail suggestions to remove the explicit effectsObserved channel and completed replay map were left in place: the explicit observed flag is now consumed by evidence/trust projection, and the completed map remains the existing replay summary surface used by tests.

@futuretyler
futuretyler merged commit 8323c8a into main Jun 28, 2026
1 check passed
@futuretyler
futuretyler deleted the salvage/recovery-hardening branch June 28, 2026 16:07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b19a825d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ledger/ledger.ts Resolved
Comment thread src/kernel/effects.ts Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant