Skip to content

fix: address Codex review guardrails - #14

Merged
futuretyler merged 1 commit into
mainfrom
codex-review-followups
Jun 28, 2026
Merged

futuretyler merged 1 commit into
mainfrom
codex-review-followups

Conversation

@futuretyler

Copy link
Copy Markdown
Owner

Summary

  • let npm run smoke:package run prepack so a clean checkout builds before packing
  • tighten loop-quality LQ003 to require step-local enforcement instead of unrelated downstream contracts
  • make trust evidence reject successful journals with no step results and mark configured missing contracts as unsafe
  • keep runs/stats/trust status listing resilient to invalid legacy run-id directories while still surfacing unsafe runs-root symlinks
  • bound symlink effect snapshots: do not recurse outside the workdir, include ctime metadata for outside targets, and keep contained POSIX names digestible

Codex review threads addressed

Verification

  • npm run verify
  • Targeted tests: npm test -- test/loop-quality.test.ts test/evidence-projection.test.ts test/trust.test.ts test/cli.test.ts test/effects.test.ts
  • Review passes: ponytail returned Lean already. Ship.; follow-up correctness blockers were fixed and covered by targeted tests.

@futuretyler
futuretyler merged commit e1a7b91 into main Jun 28, 2026
1 check passed
@futuretyler
futuretyler deleted the codex-review-followups branch June 28, 2026 17:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 482dabbc8b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/kernel/effects.ts
try {
const stat = statSync(path)
const realTarget = realpathSync(path)
if (!isContained(realRoot, realTarget)) return `symlink:${target}:outside:${statDigest(stat)}`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve detection for writes through outside directory symlinks

When a step writes through a workdir symlink that points to an outside directory, e.g. linked-dir/note.txt, this digest only records the target directory's own size/mtime/ctime; modifying an existing child file does not update those directory stats on normal filesystems. The before/after snapshots therefore stay identical and assessChanges reports no changed or unexpected path, letting a loop mutate files outside the workdir without effect-scope enforcement noticing.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant