Repository navigation
fix: address Codex review guardrails - #14
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 482dabbc8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try { | ||
| const stat = statSync(path) | ||
| const realTarget = realpathSync(path) | ||
| if (!isContained(realRoot, realTarget)) return `symlink:${target}:outside:${statDigest(stat)}` |
There was a problem hiding this comment.
Preserve detection for writes through outside directory symlinks
When a step writes through a workdir symlink that points to an outside directory, e.g. linked-dir/note.txt, this digest only records the target directory's own size/mtime/ctime; modifying an existing child file does not update those directory stats on normal filesystems. The before/after snapshots therefore stay identical and assessChanges reports no changed or unexpected path, letting a loop mutate files outside the workdir without effect-scope enforcement noticing.
Useful? React with 👍 / 👎.
Summary
npm run smoke:packagerunprepackso a clean checkout builds before packingruns/stats/trust statuslisting resilient to invalid legacy run-id directories while still surfacing unsafe runs-root symlinksCodex review threads addressed
Verification
npm run verifynpm test -- test/loop-quality.test.ts test/evidence-projection.test.ts test/trust.test.ts test/cli.test.ts test/effects.test.tsLean already. Ship.; follow-up correctness blockers were fixed and covered by targeted tests.