Skip to content

feat: add deterministic loop quality checks - #11

Merged
futuretyler merged 1 commit into
mainfrom
salvage/loop-quality-checks
Jun 28, 2026
Merged

futuretyler merged 1 commit into
mainfrom
salvage/loop-quality-checks

Conversation

@futuretyler

Copy link
Copy Markdown
Owner

Summary

  • add deterministic loop-quality evaluator and public exports
  • check typed step boundaries, provider-neutral role ids, prompt-step enforcement, bounded effect scopes, skill prompt seams, and live markers
  • add tests covering shipped templates and failure fixtures

Verification

  • npm run typecheck
  • npm test -- test/loop-quality.test.ts test/skills.test.ts test/skills-cli.test.ts test/cli.test.ts
  • npm run build

Review notes

  • Correctness review requested public package export; addressed via src/index.ts and tests now import from the root API.
  • Ponytail suggestions applied where compatible with project rules; warning/status types are retained because the plan specified the exported type surface.

@futuretyler
futuretyler merged commit bf0bc16 into main Jun 28, 2026
1 check passed
@futuretyler
futuretyler deleted the salvage/loop-quality-checks branch June 28, 2026 15:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a5bbf9267

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/kernel/loop-quality.ts Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant