Skip to content

chore(specs): security scan findings - #608

Merged
fclairamb merged 5 commits into
mainfrom
security/scan-specs-2026-10-19
Oct 19, 2026
Merged

fclairamb merged 5 commits into
mainfrom
security/scan-specs-2026-10-19

Conversation

@fclairamb

Copy link
Copy Markdown
Owner

Specs for the open findings of the daily security scan. Specs only, no code change.

Specs

Spec Severity Finding Summary
specs/todos/2026-10-19-01-a2a-response-size-cap.md medium J1 (2026-10-19) The A2A client (Agent Card fetch, SendMessage, GetTask, through the a2a-go SDK) reads success response bodies with no size cap. Only the 30 s timeout bounds them. A member pointing an A2A integration at their own server can exhaust the server's memory. Fix: a capped reader in a2aStatusTransport.

Scan of 2026-10-19 covered:

It also verified the plugin-schema $ref fix of #593 (I1). No other new finding.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@3295a20). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/internal/notifications/a2a.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage        ?   83.32%           
=======================================
  Files           ?     1238           
  Lines           ?   127041           
  Branches        ?        0           
=======================================
  Hits            ?   105860           
  Misses          ?    21172           
  Partials        ?        9           
Files with missing lines Coverage Δ
server/internal/notifications/a2a.go 86.24% <93.75%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fclairamb and others added 3 commits October 19, 2026 09:36
A user-chosen A2A agent could stream an endless 200 body to the Agent
Card fetch, SendMessage or GetTask: the SDK reads it whole. Every
successful response through a2aHTTPClient is now capped; going past
the cap fails with ErrA2AResponseTooLarge (permanent, never EOF), and
resolve-card / test report "a2a agent response exceeds 1 MiB".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fclairamb
fclairamb enabled auto-merge (squash) October 19, 2026 10:43
@fclairamb
fclairamb merged commit a0cbe75 into main Oct 19, 2026
33 checks passed
@fclairamb
fclairamb deleted the security/scan-specs-2026-10-19 branch October 19, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant