Skip to content

chore(specs): security scan findings - #593

Merged
fclairamb merged 5 commits into
mainfrom
security/scan-specs-2026-10-18
Oct 18, 2026
Merged

fclairamb merged 5 commits into
mainfrom
security/scan-specs-2026-10-18

Conversation

@fclairamb

@fclairamb fclairamb commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Specs for the open findings of the daily security scan. Specs only, no code change.

Specs

Spec Severity Finding Summary
specs/todos/2026-10-18-01-plugin-schema-file-ref.md low I1 (2026-10-18) Plugin schemas are compiled with the JSON-schema library's default loader, which opens file:// references. An agent-reported schema can therefore make the API node open local files, and whether the type gets listed reveals whether a path or JSON key exists. Fix: compiler.UseLoader with a loader that refuses every URL.

Autopilot implemented the spec (fix(plugins): refuse external $ref targets in plugin schemas) and archived it in specs/done/2026/10/. Batch gate green: make build-backend lint-back test (258 packages ok).

Decided by autopilot

None: the spec had no open questions.

Scan of 2026-10-18: the new plugin system, public tools endpoint, vendor-status check, SMS/voice quotas and MCP handshake change were reviewed. The postgres fix of #584 (G1/G2) was verified. No other new finding.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.36%. Comparing base (1a392ec) to head (3a61008).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   83.35%   83.36%           
=======================================
  Files        1235     1235           
  Lines      126548   126550    +2     
=======================================
+ Hits       105483   105497   +14     
+ Misses      21056    21044   -12     
  Partials        9        9           
Files with missing lines Coverage Δ
server/internal/plugins/config.go 87.32% <100.00%> (+0.36%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fclairamb and others added 4 commits October 18, 2026 09:44
compileSchema now installs a URL loader that refuses every load, so an
agent-reported schema can no longer make the API node open file:// paths
(security scan 2026-10-18, finding I1). Draft metaschemas and in-document
refs keep working.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pg_isready over the unix socket succeeds against the docker entrypoint's
temporary init server, which then restarts, so the final check raced it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fclairamb
fclairamb merged commit 72f1298 into main Oct 18, 2026
36 checks passed
@fclairamb
fclairamb deleted the security/scan-specs-2026-10-18 branch October 18, 2026 09:56
fclairamb added a commit that referenced this pull request Oct 19, 2026
Specs for the open findings of the daily security scan. Specs only, no
code change.

## Specs

| Spec | Severity | Finding | Summary |
|---|---|---|---|
| `specs/todos/2026-10-19-01-a2a-response-size-cap.md` | medium | J1
(2026-10-19) | The A2A client (Agent Card fetch, `SendMessage`,
`GetTask`, through the a2a-go SDK) reads success response bodies with no
size cap. Only the 30 s timeout bounds them. A member pointing an A2A
integration at their own server can exhaust the server's memory. Fix: a
capped reader in `a2aStatusTransport`. |

Scan of 2026-10-19 covered:
- the new A2A notification channel (#596), which held on egress,
tenancy, secrets and comment rendering apart from J1;
- the docs redesign;
- the dash0 changes.

It also verified the plugin-schema `$ref` fix of #593 (I1). No other new
finding.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant