Repository navigation
fix(checks): build the postgres check connection from an explicit pq.Config - #584
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 83.23% 83.23% -0.01%
==========================================
Files 1207 1208 +1
Lines 124151 124147 -4
==========================================
- Hits 103340 103335 -5
- Misses 20802 20803 +1
Partials 9 9
🚀 New features to boost your workflow:
|
…Config The PostgreSQL check no longer builds a lib/pq conninfo string. Its fields map one to one onto a pq.Config opened with pq.NewConnectorConfig, which parses no string and reads no environment: - a host, username, database or password made of backslashes, quotes, spaces or `=` can no longer add driver options (sslmode, sslcert, passfile, service...); - a check without a password no longer inherits the worker's PGPASSWORD, PGPASSFILE / ~/.pgpass, PGSSLCERT / PGSSLKEY / ~/.postgresql client certificate or PGSERVICE. PostgreSQL check credentials containing a backslash or a quote now work (they were mangled by the old escaper). BuildConnStr and escapePQParam are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…xplicitly Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…plicitly Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
fclairamb
enabled auto-merge (squash)
October 17, 2026 14:54
This was referenced Oct 17, 2026
Merged
fclairamb
added a commit
that referenced
this pull request
Oct 18, 2026
Specs for the open findings of the daily security scan. Specs only, no code change. ## Specs | Spec | Severity | Finding | Summary | |---|---|---|---| | `specs/todos/2026-10-18-01-plugin-schema-file-ref.md` | low | I1 (2026-10-18) | Plugin schemas are compiled with the JSON-schema library's default loader, which opens `file://` references. An agent-reported schema can therefore make the API node open local files, and whether the type gets listed reveals whether a path or JSON key exists. Fix: `compiler.UseLoader` with a loader that refuses every URL. | Autopilot implemented the spec (`fix(plugins): refuse external $ref targets in plugin schemas`) and archived it in `specs/done/2026/10/`. Batch gate green: `make build-backend lint-back test` (258 packages ok). ## Decided by autopilot None: the spec had no open questions. Scan of 2026-10-18: the new plugin system, public tools endpoint, vendor-status check, SMS/voice quotas and MCP handshake change were reviewed. The postgres fix of #584 (G1/G2) was verified. No other new finding. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
fclairamb
added a commit
that referenced
this pull request
Oct 18, 2026
🤖 I have created a release *beep* *boop* --- ## [0.39.0](v0.38.6...v0.39.0) (2026-10-18) ### Features * A2A notification channel for AI agents ([#596](#596)) ([2f55dc3](2f55dc3)) * **dash0:** calmer, flatter and phone-friendly dashboard UI ([#582](#582)) ([ce933cc](ce933cc)) * vendor status check, SMS/voice quotas, upgrade-path CI and flaky test fixes ([#591](#591)) ([1a392ec](1a392ec)) ### Bug Fixes * **checks:** build the postgres check connection from an explicit pq.Config ([#584](#584)) ([a4b394a](a4b394a)) * **deps:** update github.com/dop251/goja digest to 313b6b6 ([#578](#578)) ([d068c02](d068c02)) * **deps:** update github.com/dop251/goja digest to d42f16b ([#597](#597)) ([3f501a1](3f501a1)) * **deps:** update github.com/dop251/goja digest to e686264 ([#590](#590)) ([380ed48](380ed48)) * **deps:** update module github.com/knadh/koanf/v2 to v2.4.0 ([#586](#586)) ([c02a042](c02a042)) * **deps:** update module github.com/knadh/koanf/v2 to v2.4.1 ([#594](#594)) ([95e8ec3](95e8ec3)) * **deps:** update module github.com/posthog/posthog-go to v1.35.1 ([#583](#583)) ([efb4819](efb4819)) * **deps:** update module golang.org/x/mod to v0.42.0 ([#598](#598)) ([62e913d](62e913d)) * **showcase:** film a single region, as a plain docker run shows ([#595](#595)) ([a443442](a443442)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes findings G1 and G2 of the security scan of 2026-10-17 (severity low).
Change
buildPQConfigfills apq.Configdirectly andopenDBopens it withpq.NewConnectorConfig. A backslash or quote in a field can no longer add driver options (G1).PG*environment,~/.pgpassor~/.postgresqlclient certificate (G2).Passfile,SSLCertandSSLKeypoint to a path that cannot exist.BuildConnStrandescapePQParamare removed.PGCONNECT_TIMEOUTon the worker no longer affects the check; the check timeout is used.Tests
connector_test.go: hostile values arrive byte for byte in each field; a fake cleartext-auth server receives no ambient password with.pgpass,PGPASSFILE,PGPASSWORDand others set, and does receive the check's own password (positive control).Spec archived:
specs/done/2026/10/2026-10-17-01-postgres-check-connection-config.md.🤖 Generated with Claude Code