Repository navigation
Fix streaming decision enforcement and Python/SQLite scalar semantics - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The streaming workbench previously mutated cochains even when its decision said to preserve or refuse an event. It now applies only accepted repairs, respects relation and predicate scope, validates active before-images against maintained boundary fields, handles empty/new/moving groups, and exposes per-region state and quantile receipts. Untracked status changes cannot invalidate later valid deletes. Applied repair receipts include per-region revenue and count deltas, including both sides of group moves; unapplied events have no repair payload.
Quantile insertion, deletion, split/merge, and invariant verification use exact half-open comparisons on stored float bounds. Adjacent representable values, including around zero, are tested in both input orders. Bucket identifiers are never used as membership evidence.
SQLite lowering preserves scalar storage types rather than stringifying values, and Python rejects missing/null required FD fields consistently with the SQL guards. docs/CORRECTNESS_SCOPE.md records supported input domains and remaining batch/runtime boundaries.
Validation at 8833e4c: 232 tests passed on Python 3.12 (34.36s) and Python 3.14 (29.32s); git diff --check passed. Forty additional regressions cover the three review findings, including independently replaying emitted grouped deltas and checking bucket membership through insertion/removal and rebalancing. The targeted suite reproduced all three defects before the implementation fixes. Hosted CI passed all five jobs on stacked PR #19 at
83300e4(which includes correctness commit8833e4c): Python 3.10/3.14 on Linux/Windows and isolated sdist-to-wheel installation. CI run.