Repository navigation
fix: validate effective Access, DNS and endpoint configuration - #94
Merged
Merged
Conversation
- api: require true boolean selectors - controller: validate before token work - test: cover every rule list and value - docs: explain omission semantics
- dns: normalize effective provider TTL - test: preserve DNS-only transitions - test: reject repeated no-op writes - docs: retain configured TTL intent
- startup: detect conflicting listeners - test: cover flags and environment - test: preserve disabled and port zero
- test: recover DNS after cancellation - test: retain credential write intent - docs: separate removal from cleanup - docs: explain upcoming validation
- startup: match framework defaulting - test: preserve empty health disablement
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- api: leave hostname TTL unset - test: verify admission and inheritance - docs: explain stored auto TTL migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes the concrete alpha.8 audit findings in Access validation, DNS TTL convergence and manager endpoint configuration. Access rules containing
everyone: falseoranyValidServiceToken: falsefail schema and runtime validation before remote policy or token work. Proxied DNS records use Auto TTL; DNS-only records retain their configured TTL. Overlapping health and metrics bind addresses fail during configuration parsing, including an empty metrics address that resolves to the framework default.Live validation found an additional schema defect: admission inserted
ttl: 1into explicit hostname entries, preventing inheritance ofdefaults.ttl. The hostname-level default is removed. Existing storedttl: 1values remain intentional Auto overrides until removed; the migration guide explains when to do that.Validation at final head
bd48a50:Capacity remains explicitly bounded evidence: the 1,000-entry ceiling is not a supported operating size. Existing synthetic tests measure full DNS operation counts and retry progress under shared windows, but do not certify mixed-controller quota fairness. Cancellation tests verify persisted recovery state, not process SIGKILL or leader failover.
Matching chart preparation is helm-chart PR #24, including port validation, configurable termination grace, schemas and migration/decommissioning guidance. It retains the published artifact pin until alpha.9 exists.
Do not merge or release this PR yet. The proposed next operator version is
v0.2.0-alpha.9. Changelogs remain generated by the existing release workflow.