Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by bryan
Before: Lineup 1.1.0 shows profiles by name only, and every new version has to be copied to the console over FTP.
After: profile photos appear in the profile switcher, the Options menu and the header, and the app checks GitHub for a new version, downloads it, swaps its own files and reopens itself.
How: follows
docs/pt-BR/PLANO-1.2.md. The first commit is the phase 0 diagnostic build of lineupd (-DLINEUPD_DIAG, LAN port 9078), already run on the console: avatars live in/system_data/priv/cache/profile/0x<hex>/avatar.png, the app is a folder at/data/homebrew/PPSA99077mounted through nullfs, and the system's SQLite (3.51) already uses triggers ontbl_iconinfo_<user>. Defaults for the plan's open questions: check for updates on launch (once a day), no Ed25519 signature yet.Draft: commits land here as the work goes.