Adjustments to run Atlas.Query with PHP 8.5

.github/workflows/ci.yml

@@ -41,6 +41,7 @@ jobs:
           - '8.2'
           - '8.3'
           - '8.4'
+          - '8.5'
     steps:
       - uses: actions/checkout@v4
 
@@ -78,6 +79,7 @@ jobs:
           - '8.2'
           - '8.3'
           - '8.4'
+          - '8.5'
     steps:
       - uses: actions/checkout@v4
 

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Change Log
 
+## Unreleased
+
+- Explicitly nullable params in test helpers.
+- Test last insert IDs with omitted and null names.
+- Upgrade PHPStan to 1.0.
+- Add PHP 8.5 to Github workflow.
+
 ## 2.0.0
 
 Initial release.

composer.json

@@ -37,7 +37,7 @@
     "require-dev": {
         "pds/skeleton": "^1.0",
         "phpunit/phpunit": "~9.0",
-        "phpstan/phpstan": "^0.12.82"
+        "phpstan/phpstan": "^1.0"
     },
     "autoload": {
         "psr-4": {

tests/FakeConnection.php

@@ -41,7 +41,7 @@ public function perform(string $statement, array $values = []) : PDOStatement
         return new PDOStatement();
     }
 
-    public function lastInsertId(string $name = null) : string
+    public function lastInsertId(?string $name = null) : string
     {
         return "{$name}-1";
     }

tests/InsertTest.php

@@ -16,4 +16,18 @@ public function testGetLastInsertId()
         $actual = $query->getLastInsertId('foo');
         $this->assertSame('foo-1', $actual);
     }
+
+    public function testGetLastInsertId_withoutName()
+    {
+        $query = $this->newQuery();
+        $actual = $query->getLastInsertId();
+        $this->assertSame('-1', $actual);
+    }
+
+    public function testGetLastInsertId_withNullName()
+    {
+        $query = $this->newQuery();
+        $actual = $query->getLastInsertId(null);
+        $this->assertSame('-1', $actual);
+    }
 }

tests/QueryTestCase.php

@@ -19,7 +19,7 @@ protected function getQueryClass()
         return substr(get_class($this), 0, -4);
     }
 
-    protected function newQuery(string $arg = null)
+    protected function newQuery(?string $arg = null)
     {
         if ($arg === null) {
             $arg = new FakeConnection('fake');