Repository navigation
Conversation
Remove implicit nullable parameter deprecations from test helpers and cover last insert IDs with omitted and null names. Upgrade PHPStan to 1.x and extend both CI matrices to PHP 8.5 while retaining PHP 8.0 support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #21 to run the tests and static analysis on PHP 8.5 while retaining PHP 8.0 support.
getLastInsertId()with omitted and null names.^1.0, matching Atlas.Pdo.No production code or public method signatures are changed.
Verified tests and PHPStan on PHP 8.0, 8.1, 8.2, 8.3, 8.4, and 8.5. All versions pass 12 tests with 18 assertions, and PHPStan reports no errors.