Repository navigation
Fix heat meter and unused input parsing - #49
Merged
Merged
Conversation
This was referenced Nov 16, 2026
The heat meter register uses bit 0 for meter 1 and bit 1 for meter 2, but the parser tested `active & position`, so meter 1 was never reported and meter 2 showed garbage whenever meter 1 was active. Inputs of type 000 are unused according to TA's interface spec and are now returned as None instead of their raw value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A temperature input without sensor or with a broken wire reads all value bits set, 409.5 °C, which no real sensor reaches. Return None for it like for unused inputs, so fetch() leaves it out instead of reporting 409.5 °C. Confirmed with the hydraulics chart of the recorded BL-NET: inputs 1-5 and 15 have no sensor connected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nielstron
force-pushed
the
fix/parser-inputs
branch
from
November 16, 2026 14:27
35abfe6 to
3c524c3
Compare
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #48 (by Alexander Eisele), without the fork-specific changes (uv migration, Python 3.11 requirement, pyupgrade, PyPI/README fork changes, CLAUDE.md, version bumps).
active & position: meter 1 was never reported, meter 2 showed garbage when meter 1 was active.Noneinstead of their raw value.None.New parser tests fail on master and pass here.