Skip to content

Fix heat meter and unused input parsing - #49

Merged
nielstron merged 2 commits into
masterfrom
fix/parser-inputs
Nov 16, 2026
Merged

nielstron merged 2 commits into
masterfrom
fix/parser-inputs

Conversation

@nielstron

Copy link
Copy Markdown
Member

Cherry-picked from #48 (by Alexander Eisele), without the fork-specific changes (uv migration, Python 3.11 requirement, pyupgrade, PyPI/README fork changes, CLAUDE.md, version bumps).

  • Heat meter register uses bit 0 for meter 1 and bit 1 for meter 2, but the parser tested active & position: meter 1 was never reported, meter 2 showed garbage when meter 1 was active.
  • Inputs of type 000 are unused per TA's spec and now return None instead of their raw value.
  • Temperature inputs without sensor (all value bits set, 409.5 °C) now return None.

New parser tests fail on master and pass here.

dereisele and others added 2 commits November 16, 2026 15:26
The heat meter register uses bit 0 for meter 1 and bit 1 for meter 2,
but the parser tested `active & position`, so meter 1 was never reported
and meter 2 showed garbage whenever meter 1 was active.

Inputs of type 000 are unused according to TA's interface spec and are
now returned as None instead of their raw value.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A temperature input without sensor or with a broken wire reads all
value bits set, 409.5 °C, which no real sensor reaches. Return None for
it like for unused inputs, so fetch() leaves it out instead of
reporting 409.5 °C. Confirmed with the hydraulics chart of the recorded
BL-NET: inputs 1-5 and 15 have no sensor connected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nielstron
nielstron merged commit 6d37af7 into master Nov 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants