Repository navigation
Fix fetching via BLNETDirect in DL mode / without web interface - #50
Merged
Merged
Conversation
nielstron
force-pushed
the
fix/parser-inputs
branch
from
November 16, 2026 14:27
35abfe6 to
3c524c3
Compare
nielstron
force-pushed
the
fix/direct-dl-mode
branch
from
November 16, 2026 14:27
78fad9e to
bec87d3
Compare
- get_value() raised KeyError because values fetched only via blnet_direct have no name; match on the id key instead - get_latest() stored the string "timeout" as a frame, which crashed fetch(), and also did so when the last retry succeeded; timed out frames are now listed in info["timeout"] and fetch() raises ConnectionError if no data arrived - BLNETDirect set the process-wide default socket timeout, and only after the first connection; the timeout is now set on its own sockets Adds a fake TCP BL-NET replaying responses recorded from a real device in DL mode, so BLNETDirect is covered by tests for the first time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nielstron
force-pushed
the
fix/direct-dl-mode
branch
from
November 16, 2026 14:35
bec87d3 to
6b10c30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #48 (by Alexander Eisele), without the fork-specific changes (uv migration, Python 3.11 requirement, pyupgrade, PyPI/README fork changes, CLAUDE.md, version bumps).
Needed #49 (now merged): the recorded DL-mode data has heat meter 1 active.
struct.unpackin DL/DL2 mode was missing thedataargument (TypeError).use_web=False, analog/digital values from the direct connection were dropped since there were no web entries to update.get_value()raised KeyError for entries without a name;get_latest()stored the string "timeout" as a frame;BLNETDirectset the process-wide default socket timeout (and only after the first connect).Each commit's tests fail with that commit's code change reverted.