Repository navigation
Conversation
Keep native-host and OCR failure details visible with copy and dismiss controls, and navigate successful enhancement results to the extension viewer rather than appending a query to the source PDF URL. Add regression coverage for SEC MIME-handler tabs and failed uploads. Co-authored-by: Codex Web <noreply@openai.com>
Include the setup close button and tools menu controls referenced by enhancer initialization so the regression fixture faithfully mounts the module. Co-authored-by: Codex Web <noreply@openai.com>
Run the Enhancer's isolated Python setup when installing its native host and prefer that environment for metadata stamping. Add host regression coverage and explain the setup behavior. Co-authored-by: Codex Web <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Enhance can stay at 0% then disappear without a persistent error because its native-host failures are shown only as short-lived toasts. Under Chrome's PDF MIME handler, successful enhancement may also append
?url=file://...to the SEC PDF address instead of reopening the extension viewer.Changes
.venvduring explicit local native-host setup when the selected checkout hassetup-python-env.sh; leave older forks compatible.Related
The Enhancer-side Python venv setup, preferred interpreter and shell startup fixes are in PDF-magic/enhancer#12. Reported against https://www.sec.gov/files/rules/sro/dtc/2009/dtcresponse101509.pdf.
The exact failure on the user's local installation remains unverified; the viewer now exposes errors instead of hiding them.