Repository navigation
Conversation
Accept a working python3 command even when it is not a relative executable file, and inspect OCRmyPDF's shebang only after dependency checks. Cover the startup path with a stubbed OCR regression test. Co-authored-by: Codex Web <noreply@openai.com>
Generate executable shell stubs with actual line breaks so the regression reaches the interpreter-selection path. Co-authored-by: Codex Web <noreply@openai.com>
Preserve interpreter arguments discovered from OCRmyPDF's shebang when invoking the tagger, reviewer, and sidecar exporter. Co-authored-by: Codex Web <noreply@openai.com>
Include OCR shell changes in the existing regression workflow and execute its startup test alongside metadata checks. Co-authored-by: Codex Web <noreply@openai.com>
Add a dedicated setup script for the project .venv, prioritize it for OCR and compression helpers, retain backward-compatible interpreter selection for existing installations, and test venv precedence and diagnostics. Co-authored-by: Codex Web <noreply@openai.com>
Assert file markers from test interpreter shims because dependency checks intentionally redirect output to /dev/null. Co-authored-by: Codex Web <noreply@openai.com>
JFWooten4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OCR shell script checked
[[ -x "$tagger_python" ]]whiletagger_python=python3, which inspects a relative file rather than resolving an executable onPATH. More importantly, the workflow did not explicitly select an Enhancer-owned Python virtual environment and could mix global/Homebrew Python packages with its own tagging, compression, and review scripts.Changes
setup-python-env.shto createenhancer/.venvand installpikepdfand Pillow..venv/bin/pythonconsistently for OCR tagging, review and sidecars, plus compression workflows. Report an actionable repair message when the venv is incomplete.PATH/ OCRmyPDF interpreter fallback when no project venv exists, preserving standalone compatibility.python3PATH issue. Run shell startup checks in CI.Integration
The viewer's native-host installer is updated separately in PDF-magic/viewer#203 to provision the project venv on explicit setup and prefer it for metadata stamping.
These changes address demonstrable startup and environment-selection problems; the reported SEC PDF failure cannot be reproduced on the user's Mac from CI.