Repository navigation
Refactor LoginForm to use react-hook-form and zod for validation - #59
Merged
maneesha-xyz merged 9 commits intoNov 11, 2026
Merged
Conversation
- Replaced manual state management and validation with react-hook-form and zod. - Introduced a login schema using zod for email and password validation. - Updated form submission handling to utilize the new validation approach. - Adjusted the LoginPage to type the form data correctly.
…ion in AddAccountForm
… and ComposePanel
…on and submission
sanjaiyan-dev
marked this pull request as ready for review
November 9, 2026 14:56
Contributor
Author
|
Hi @maneesha-xyz , whenever you have some time, this PR is ready for review. No rush at all, please take your time. Any feedback would be greatly appreciated. Thank you! |
Member
|
@sanjaiyan-dev there are some conflicts. |
…nctionality - Added mini search capabilities to filter email threads based on subject, last message, and participants. - Improved sidebar resizing logic with better performance using requestAnimationFrame. - Added keyboard shortcuts for quick sidebar resizing and default width reset on double-click. - Enhanced error handling for localStorage operations. - Refactored search handling to utilize useDeferredValue for smoother user experience.
Contributor
Author
Hi @maneesha-xyz, I’ve resolved the merge conflicts with main. The PR is ready for review again whenever you have time. Thank you! |
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors form handling and validation across the application by migrating from manual
useStateform management toreact-hook-formpaired withzodschema validation (@hookform/resolvers). Also includes memory and performance optimizations for recipient parsing in bulk-email workflows.Summary of Changes
Form Migrations & Validation:
LoginForm,RegistrationForm,AddAccountForm,ProfileForm, andComposeForm/ComposePaneltoreact-hook-form(useForm,Controller,useWatch).zodand@hookform/resolvers.react-hook-form,zod, and@hookform/resolvers.Type Safety:
LoginFormData,RegistrationFormData, etc.).LoginPage,RegisterPage,ComposePage) to use strongly typed submit handlers.Bulk Recipient Parsing Optimization (
ComposePage):parseRecipientsfrom chained array operations (.map().filter().map()) to a singlefor...ofloop.Demo & Performance Proof
Screen.Recording.2026-11-06.at.19.35.33.mov
Screen.Recording.2026-11-06.at.19.34.24.mov