Skip to content

fix: Refactor form handling and improve loading state management - #62

Merged
maneesha-xyz merged 5 commits into
OpenGovMail:mainfrom
sanjaiyan-dev:sanjaiyan-react-hook-form-cleanup
Nov 18, 2026
Merged

maneesha-xyz merged 5 commits into
OpenGovMail:mainfrom
sanjaiyan-dev:sanjaiyan-react-hook-form-cleanup

Conversation

@sanjaiyan-dev

Copy link
Copy Markdown
Contributor

Hi @maneesha-xyz, very sorry for the inconvenience! A few bugs slipped in during the merge conflict resolution in #60, and I had also missed converting PasswordResetForm. Really apologize for the extra review.

Changes

  • Removed leftover setSubmitting(false) / setLoading(false) calls in AddAccountForm and ProfileForm.
  • Updated LoginForm, RegistrationForm, and PasswordResetForm to use isSubmitting (loading || isSubmitting) so loading states reset properly.
  • Converted PasswordResetForm to react-hook-form (replacing manual state/validation).

Sorry again for missing these in #60 & #59 —please let me know if anything else needs adjusting!

@sanjaiyan-dev
sanjaiyan-dev marked this pull request as ready for review November 16, 2026 18:40
@maneesha-xyz
maneesha-xyz self-requested a review November 17, 2026 04:11
@maneesha-xyz

Copy link
Copy Markdown
Member

Hi @sanjaiyan-dev there are some conflicts that need to be addressed.

- Added hotkeys in ThreadPage for replying, replying all, and forwarding emails, with conditions to disable when modal is open.
@sanjaiyan-dev

Copy link
Copy Markdown
Contributor Author

@maneesha-xyz Hi, it’s done; I’m sorry I included a minor package version bump with this PR (I believe those were only minor updates).

@maneesha-xyz maneesha-xyz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maneesha-xyz
maneesha-xyz merged commit 3056a47 into OpenGovMail:main Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants