Repository navigation
fix: Refactor form handling and improve loading state management - #62
Merged
maneesha-xyz merged 5 commits intoNov 18, 2026
Merged
maneesha-xyz merged 5 commits into
maneesha-xyz merged 5 commits into
Conversation
sanjaiyan-dev
marked this pull request as ready for review
November 16, 2026 18:40
maneesha-xyz
self-requested a review
November 17, 2026 04:11
Member
|
Hi @sanjaiyan-dev there are some conflicts that need to be addressed. |
- Added hotkeys in ThreadPage for replying, replying all, and forwarding emails, with conditions to disable when modal is open.
Contributor
Author
|
@maneesha-xyz Hi, it’s done; I’m sorry I included a minor package version bump with this PR (I believe those were only minor updates). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @maneesha-xyz, very sorry for the inconvenience! A few bugs slipped in during the merge conflict resolution in #60, and I had also missed converting
PasswordResetForm. Really apologize for the extra review.Changes
setSubmitting(false)/setLoading(false)calls inAddAccountFormandProfileForm.LoginForm,RegistrationForm, andPasswordResetFormto useisSubmitting(loading || isSubmitting) so loading states reset properly.PasswordResetFormtoreact-hook-form(replacing manual state/validation).Sorry again for missing these in #60 & #59 —please let me know if anything else needs adjusting!