Repository navigation
feat(studio): X01a eval gate runner over observe datasets - #1115
Merged
Merged
Conversation
5 tasks done
spec.evals becomes a real AgentSpecV2 section (EvalGateSpec: dataset, single-key gates, minPassRate) replacing the pending placeholder, and server/evals/ gains the runner X01b will call from publish: dataset fetch capped at 50 examples, deterministic gate checks, model judge via PassRunner eval_judge jobs, and candidate runs through the spec-v2 build path under a separate -evals observe name with a 60 s per-example cap. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
LinuxDevil
force-pushed
the
fb-x01a-eval-gate
branch
from
November 14, 2026 10:47
1b879c5 to
d60a6c0
Compare
The deep relative specifiers tripped lousho/no-sdk-source in lint:imports; both types are already re-exported from the public spec subpath. Document the EvalGate union members the re-export surfaced to typedoc. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.evalsbecomes a realAgentSpecV2section:EvalGateSpec(dataset, single-key gates —calledTool/notCalledTool/maxCostUsd/maxSteps/judge— andminPassRate), replacing thependingFieldplaceholder; strict zod schema with per-gate variant checks and top-level-only key handling for inline subagents.apps/agent-forge/server/evals/runner (runEvalGates): fetches each named observe dataset (cap 50 examples), runs candidates sequentially through the spec-v2 build path under a separate<agentId>-evalsobserve name, applies deterministic gate checks, and gradesjudgegates through PassRunnereval_judgejobs (sha256-keyed dedupe, 20 s timeout). Missing/empty/unreachable datasets and unavailable judges all fail — a gate that could not be checked never passes.setTimeout+AbortControllerso fake timers can drive it;now/fetch/runExampleinjectable for tests.evalsread updated now that the section is real; canvasspecTypesre-exports the SDKEvalGateSpec.X01b (publish wiring + 409 + UI) lands next —
runEvalGatesintentionally has no route caller yet.Test plan
npm run typecheck:server --workspace apps/agent-forgenpm run test:server --workspace apps/agent-forge(export fixtures updated to the real eval shape)evals.test.tsnpm run fallow— dead code clean; health findings are the pre-existing baselineGenerated with Devin