Repository navigation
feat(studio): X01b run the eval gate on publish and show failures - #1116
Merged
Merged
Conversation
spec.evals becomes a real AgentSpecV2 section (EvalGateSpec: dataset, single-key gates, minPassRate) replacing the pending placeholder, and server/evals/ gains the runner X01b will call from publish: dataset fetch capped at 50 examples, deterministic gate checks, model judge via PassRunner eval_judge jobs, and candidate runs through the spec-v2 build path under a separate -evals observe name with a 60 s per-example cap. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
POST /agents/:id/publish now runs runEvalGates when the pinned version's spec declares evals: a module-level busy set answers concurrent publishes with 409 LOUSHO_EVAL_GATE_BUSY, a failed gate adds a publish_failed inbox alert and answers 409 LOUSHO_EVAL_GATE_FAILED carrying the full EvalGateResult plus the refused version, and only a passing gate moves meta.publishedVersion. EvalGateResult and friends move to shared wire types; the publish pill spins a Loader2 and reads "Running evals…" while waiting, toasts "· evals passed" on a gated success, and both publish surfaces open the new EvalGateDialog (per-set rates, failing examples, trace links) on the 409. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
3 tasks done
LinuxDevil
force-pushed
the
fb-x01a-eval-gate
branch
from
November 14, 2026 10:47
1b879c5 to
d60a6c0
Compare
…gate # Conflicts: # apps/agent-forge/server/app.ts # apps/agent-forge/server/evals/gateRunner.ts # apps/agent-forge/server/lifecycle/publish.ts # apps/agent-forge/src/graph/v2/specTypes.ts # src/spec/v2/evals.ts # src/spec/v2/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /agents/:id/publishrunsrunEvalGateswhen the pinned version's spec declaresevals(stacked on feat(studio): X01a eval gate runner over observe datasets #1115): concurrent publishes get 409LOUSHO_EVAL_GATE_BUSY, a failed gate adds apublish_failedinbox alert and answers 409LOUSHO_EVAL_GATE_FAILEDwith the fullEvalGateResult+ refused version; only a passing gate movesmeta.publishedVersion.EvalGateResult/EvalGateSetResult/EvalExampleResultmove toshared/wireTypes.ts;RuntimeClient.publish(agentId, { version? })returnsPublishResponseandRuntimeApiErrorgains abodyfield for the gate payload.EvalGateDialog(per-set pass rates vs floors, failing examples with trace links,+n morecap) opened by both publish surfaces — the toolbar pill (nowRunning evals…+ Loader2 while waiting,· evals passedtoast on gated success) and VersionsTab's "Publish this".Test plan
publishEvalGate.test.ts: pass / fail+alert / busy / no-evals / repin-no-rerun (5 tests)EvalGateDialog.test.tsx: set rows, % formatting, error row, 10-example cap, trace href, Close-only footerPublishPill.test.tsx+VersionsTab.test.tsx: busy label, dialog on 409, evals-passed toastruntimeClient.test.ts: publish body, evalResult, 409 body retentiontypecheck,typecheck:server, full client suite (4089), server suite (1722 + known idleVersions flake), fallow dead-code/dupes clean, contrast pair addedGenerated with Devin