Skip to content

feat: Skip result JSON output in write_outputs - #318

Merged
Siel merged 1 commit into
mainfrom
skip-result-json
Aug 28, 2026
Merged

Siel merged 1 commit into
mainfrom
skip-result-json

Conversation

@Siel

@Siel Siel commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

  • stop write_outputs from creating result.json
  • keep write_json available for explicit JSON exports

Pmetrics reads the CSV artifacts and does not consume this JSON file. Skipping it avoids serializing large prior, prediction, and cycle matrices after fitting.

Tests

  • cargo fmt --check
  • cargo test

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

ProjectPMcore
Branchskip-result-json
Testbedmhovd-pgx
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
bimodal_ke_npag📈 view plot
🚷 view threshold
3,548.50 ms
(-22.82%)Baseline: 4,597.64 ms
6,273.26 ms
(56.57%)
bimodal_ke_npod📈 view plot
🚷 view threshold
989.29 ms
(-27.96%)Baseline: 1,373.24 ms
2,088.11 ms
(47.38%)
bimodal_ke_postprob📈 view plot
🚷 view threshold
403.62 ms
(+4.34%)Baseline: 386.82 ms
878.09 ms
(45.97%)
🐰 View full continuous benchmarking report in Bencher

@mhovd

mhovd commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

I don't think the JSON itself is the problem, but the fact that we are writing the full theta for each cycle - that is the real killer. But I am not opposed to these changes.

@Siel

Siel commented Aug 28, 2026 via email

Copy link
Copy Markdown
Member Author

@mhovd mhovd changed the title Skip result JSON output feat: Skip result JSON output in write_outputs Aug 28, 2026
@Siel
Siel merged commit 789a415 into main Aug 28, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants