Repository navigation
feat: Update to pharmsol 0.29.0 - #317
Merged
Merged
Conversation
Breaking change because of features
Contributor
There was a problem hiding this comment.
Pull request overview
Updates pmcore to use pharmsol v0.29.0 and adjusts crate features / call sites to match the updated DSL/runtime API surface.
Changes:
- Bump
pharmsoldependency to=0.29.0. - Consolidate DSL feature flags into a single
dslfeature and update conditional compilation accordingly. - Update/remove affected examples and tweak a nonparametric test expectation to match new solver behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Bumps pharmsol to 0.29.0 and replaces multiple DSL feature flags with a single dsl feature; updates example required features. |
src/model/mod.rs |
Simplifies EquationMetadataSource impl gating to #[cfg(feature = "dsl")] for runtime DSL model types. |
tests/onecomp.rs |
Updates expected NPOD cycle count to align with new library behavior. |
examples/bestdose/main.rs |
Updates runtime DSL compilation call to match the updated pharmsol::dsl API (removes explicit compilation target). |
examples/bimodal_ke_backend_compare.rs |
Removes the backend comparison example (file deleted). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // Check the results | ||
| assert_eq!(result.cycles(), 12); | ||
| assert_eq!(result.cycles(), 11); | ||
| assert!(result.objf() - 565.7749 < 0.01); |
Contributor
|
| Project | PMcore |
| Branch | pharmsol-0.29.0 |
| Testbed | mhovd-pgx |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 2,899.50 ms(-36.63%)Baseline: 4,575.22 ms | 6,268.74 ms (46.25%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 972.15 ms(-28.74%)Baseline: 1,364.27 ms | 2,084.77 ms (46.63%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 405.04 ms(+4.61%)Baseline: 387.20 ms | 872.19 ms (46.44%) |
Siel
approved these changes
Aug 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change because of features