Skip to content

feat: Update to pharmsol 0.29.0 - #317

Merged
Siel merged 3 commits into
mainfrom
pharmsol-0.29.0
Aug 28, 2026
Merged

Siel merged 3 commits into
mainfrom
pharmsol-0.29.0

Conversation

@mhovd

@mhovd mhovd commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Breaking change because of features

Breaking change because of features
Copilot AI lite review requested due to automatic review settings August 27, 2026 13:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates pmcore to use pharmsol v0.29.0 and adjusts crate features / call sites to match the updated DSL/runtime API surface.

Changes:

  • Bump pharmsol dependency to =0.29.0.
  • Consolidate DSL feature flags into a single dsl feature and update conditional compilation accordingly.
  • Update/remove affected examples and tweak a nonparametric test expectation to match new solver behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Cargo.toml Bumps pharmsol to 0.29.0 and replaces multiple DSL feature flags with a single dsl feature; updates example required features.
src/model/mod.rs Simplifies EquationMetadataSource impl gating to #[cfg(feature = "dsl")] for runtime DSL model types.
tests/onecomp.rs Updates expected NPOD cycle count to align with new library behavior.
examples/bestdose/main.rs Updates runtime DSL compilation call to match the updated pharmsol::dsl API (removes explicit compilation target).
examples/bimodal_ke_backend_compare.rs Removes the backend comparison example (file deleted).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/onecomp.rs
// Check the results
assert_eq!(result.cycles(), 12);
assert_eq!(result.cycles(), 11);
assert!(result.objf() - 565.7749 < 0.01);
@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

ProjectPMcore
Branchpharmsol-0.29.0
Testbedmhovd-pgx
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
bimodal_ke_npag📈 view plot
🚷 view threshold
2,899.50 ms
(-36.63%)Baseline: 4,575.22 ms
6,268.74 ms
(46.25%)
bimodal_ke_npod📈 view plot
🚷 view threshold
972.15 ms
(-28.74%)Baseline: 1,364.27 ms
2,084.77 ms
(46.63%)
bimodal_ke_postprob📈 view plot
🚷 view threshold
405.04 ms
(+4.61%)Baseline: 387.20 ms
872.19 ms
(46.44%)
🐰 View full continuous benchmarking report in Bencher

@Siel
Siel merged commit 684aee8 into main Aug 28, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants