Repository navigation
Serendipity cells with 64-bit point data slice; VTK's three-axis extent on flat curvilinear grids - #350
Merged
Conversation
…nt on flat curvilinear grids Slicing or contouring a quad8, hex20 or wedge15 carrying a 64-bit integer point field failed: the field's full values asked a device for what a backend has. extract_extent of a flat curvilinear grid refused VTK's three-axis extent and rates; the flat axis is the one whose pair is (0, 0). Found running VTK's cutter.py and NetCDFCF2DBounds.py on Tack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes found by running VTK's own Python tests with Tack's algorithms in place of VTK's filters.
'Device' object has no attribute 'supports_f64'--_serendipity.full_valuespassed the topology's device where_float_typetakes a backend (it asks only for 64-bit integers). VTK'scutter.py(cuttertest.vtu's node numbers).extract_extentof a flat curvilinear grid refused VTK's three-axis extent and rates: VTK always writes three, and only an image's or rectilinear grid's coordinates said which axis is flat. A curvilinear grid's flat axis is now the one whose pair is(0, 0), as VTK writes it (else the first two). VTK'sNetCDFCF2DBounds.py.Tested: a slice of each serendipity cell with a 64-bit point field (failed before), and flat curvilinear grids in the xz and xy planes against
vtkExtractGrid. Files touched 202 passed; quick tier 3040 passed.🤖 Generated with Claude Code