Repository navigation
tools/vtk_test_ports: VTK's Python tests with Tack's algorithms in place of VTK's filters - #354
Merged
Merged
Conversation
…ace of VTK's filters Stand-ins of VTK's filter classes over a real VTK twin: the twin holds the test's settings, the stand-in runs the Tack wrapper they translate to and records its output against the twin's (counts, bounds, measures, array ranges); a setting Tack has no counterpart for, or a Tack error, gives the twin's output and the reason. A driver runs tests both ways in parallel with VTK's image checks, and a report summarizes them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The harness behind #343, #344, #345, #348, #349, #350, #352 and #353: VTK's own Python tests run with Tack's VTK algorithms in place of VTK's filters, as a robustness test of Tack's filters on the data and pipelines VTK's tests build (not a check that Tack replaces VTK's filters one for one).
shims.py: a stand-in for each VTK filter class Tack has, in itsvtkmodulesmodule. It keeps a real VTK filter as its twin, which takes every call the stand-in does not answer, so the twin holds the test's settings; when run, the stand-in translates them to a Tack wrapper, gives its output (converted to VTK's class), and records it against the twin's: counts, bounds over the points cells use, total length, area and volume, array ranges, and a verdict. A setting Tack has no counterpart for, or a Tack error, gives the twin's output and records why.run_one.py: one test as VTK's test driver runs it (rtImageTest), offscreen, with VTK's filters or Tack's, its image against VTK's baseline.drive.py: a list of tests both ways, in parallel, intosummary.json;report.pysummarizes it.README.md: how it works, how to run it, and what it found.Not run by CI: it needs VTK's source tree, test data and baselines.
🤖 Generated with Claude Code