Repository navigation
Move the college list to Overview and open Status on a summary - #88
Merged
Merged
Conversation
The student's list, with its map and cost box, sat at the top of Discover, which answered the wrong question there: Discover is for finding schools that are not on the list yet, so the list itself belongs on the module's front page. It moves to Overview, above the checklist, and its main link now goes to Discover to add more rather than back to Application Status. "+N more" still goes to the full list, since that is a different place to want to be. The Overview checklist is now titled Applications 101; the section inside it keeps the name Application Strategy, which would read oddly as a peer of Submission Workflow otherwise. Application Status opened straight into every school's row. It now opens on a summary — where each application stands, what is due next, the season's timeline, and the tasks shared across the list — with the rows one level in behind "See all N schools". A status chip on the summary opens the list already filtered by it. The list reuses the item slot in the URL that a school's page already used, under the id "all", so it gets a Back step and survives a refresh without any new routing. Two things fell out of that. The school page's Back went to the tab root, which is now the summary, so opening a school from the list and going back skipped past the list it came from; its own label already promised "All applications", so it points there. And the strip needed the ZIP geocode and effective profile that Discover had been keeping to itself, so those move into useCollegePrefs, where both callers share them — getSettings already dedupes the in-flight read and geocodeZip caches, so the second caller costs no request. The strip's own tests move with it, rendering the component directly rather than reaching it through Discover's feed. Discover's saved-list boost tests counted the strip's fetch as well as the boost's; only the boost fetches there now.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying timeline-prototype with
|
| Latest commit: |
0aee261
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5b6674e.timeline-prototype.pages.dev |
| Branch Preview URL: | https://feature-application-status.timeline-prototype.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four changes to Application Tracking.
The college list moves from Discover to Overview. It sat at the top of
Discover, answering the wrong question there — Discover is for finding schools
that are not on the list yet. It now sits above the checklist on the module's
front page, and its main link goes to Discover to add more rather than back to
Application Status. "+N more" still goes to the full list, which is a different
place to want to be.
The Overview checklist is now titled "Applications 101." The section inside
it keeps the name "Application Strategy" — renaming that one would leave
"Applications 101" sitting as a peer of "Submission Workflow" and "After You
Submit".
Application Status opens on a summary instead of straight into every
school's row: where each application stands, what is due next, the season's
timeline, and the tasks shared across the list. The rows are one level in,
behind "See all N schools". A status chip on the summary opens the list already
filtered by it. This reuses the URL item slot a school's page already used,
under the id
all, so it gets a Back step and survives a refresh with no newrouting.
Two things that fell out of it
opening a school from the list and going back skipped past the list it came
from. Its own label already promised "All applications", so it points there.
keeping to itself. Those move into
useCollegePrefs, where both callers sharethem.
getSettingsalready dedupes the in-flight read andgeocodeZipcaches, so the second caller costs no extra request.
Tests
The strip's own tests move with it into
YourListStrip.test.tsx, rendering thecomponent directly rather than reaching it through Discover's feed. Discover's
saved-list boost tests counted the strip's fetch as well as the boost's; only
the boost fetches there now.
Local:
tscclean,eslintclean, 723 tests passing, production build OK.Not covered
There is no test for
ApplicationTrackingModuleitself, so the Overview→stripprop wiring is covered by the typechecker and the build but not by a render. I
reviewed the three views against fixture data; map pins need lat/lng from the
database, so a pin has not been seen rendering in its new location.