Repository navigation
Open on Overview; 101 tabs for both modules; own FAFSA/CSS dates - #89
Merged
Merged
Conversation
Financial Aid and Application Tracking now open on Overview; a tab named in the URL still wins. Financial Aid's whole checklist moves into Scholarships 101, the content team's scholarship steps first, so Overview keeps only the FAFSA and CSS Profile boxes, the stats and "Know your aid". Every item keeps its id and the student's progress on it. Where a school has no FAFSA or CSS date on file, Aid Tracker's boxes let the student add their own. It is kept on the school's Application Tracking entry (fafsaDate, cssDate), so the calendar shows it as that school's date.
Deploying timeline-prototype with
|
| Latest commit: |
7196aa6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://230c5d03.timeline-prototype.pages.dev |
| Branch Preview URL: | https://feature-overview-first.timeline-prototype.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Application Tracking now matches Financial Aid. Its Overview is the list at a glance: Discover's map and balance strip under a note for the student's grade, beside the week's deadlines. The checklist moves to a new Application 101 tab, keeping every item's progress; the fee-waiver banner's article link goes there. Discover keeps its strip; working out where the student lives from their ZIP is now one shared hook. Financial Aid's FAFSA and CSS boxes said "Add schools" while Application Tracking's list was still loading. They now wait for it.
…d Application 101 on top
DanialBeg
added a commit
that referenced
this pull request
Nov 2, 2026
…n top #89 restructured the same four files. Application Tracking and Financial Aid now open on a real Overview and keep their articles in their own tab — Application 101 and Scholarships 101 — and Financial Aid's Overview no longer holds a reader at all. That shape is kept whole; this change is re-applied on top of it rather than beside it. So the routed article follows the articles: Application Tracking reads it on `application-101` rather than `overview`, and Financial Aid on `scholarships-101` only, validated against CHECKLIST_ALL_IDS now that every article lives there. ModuleOverviewTab keeps #89's `backLabel` alongside the controlled reader. The two tabs #89 kept remounting with `key={openItem}` keep the nav counter, since a same-tab click leaves that key unchanged and the sidebar would still do nothing. Financial Aid's Overview links into an article with `read101`, which now routes it instead of seeding a remount, so an article reached that way has the same exits as any other. That relies on a later setItem winning over the one setTab clears in the same batch, which was assumption rather than fact, so hashRoute now tests it. `tsc --noEmit` does not see the test files; `tsc -b` does, and it is what CI runs. Four type errors were hiding behind that difference, all of them props the restructure moved.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Both modules open on Overview. Opening Financial Aid or Application Tracking from the dashboard now lands on Overview. They used to open on Aid Tracker and Application Status. A tab named in the URL still wins, as before: a refresh, back/forward, or a link such as "Add schools in Application Tracking", which opens Discover.
Financial Aid
All of Financial Aid's articles are in Scholarships 101. The tab now holds the module's whole checklist as collapsible sections, with one progress bar for all 18 items:
The rest of the move:
Students can add their own FAFSA and CSS dates. In Aid Tracker's boxes, a school with no date on file shows "+ Add date" next to "No date on file", "Required" or "Check its aid page". It uses the date picker scholarships already use.
fafsaDateandcssDate. The list is saved as JSON, so no migration is needed.Loading fix. While Application Tracking's list was still loading, the FAFSA and CSS boxes briefly said "Add schools in Application Tracking", even to students who had schools. They now say "Checking your schools…" until the list is in.
Application Tracking
Builds on #88, which merged while this was open. #88 had moved the college list strip (map, balance, costs) from Discover to the top of Overview, above the checklist. That stays, and Discover stays without it.
New Overview, laid out like Financial Aid's. A "Building Your List" badge, a heading, a short note for the student's grade, #88's list strip with its map, and the This week panel. While the list is still loading it says "Loading your list…", not "Your list is empty".
Application 101 (new tab). The checklist moves off Overview into its own tab: building the list, application strategy, submission workflow and after you submit, 15 items.
Cleanup:
beforeslot Move the college list to Overview and open Status on a summary #88 added to the sharedModuleOverviewTabhas no callers now, so it's removed.ModuleOverviewTabgainsbackLabelinstead.Database
None.
Checks