Skip to content

Finish lifecycle cleanup and remove stale qualification documents #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShadowNineX merged 2 commits into from
Oct 25, 2026
Merged

Finish lifecycle cleanup and remove stale qualification documents #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05a56f7
fix lifecycle cleanup and retire stale qualification documents
ShadowNineX Oct 25, 2026
0e452a4
Fix shutdown review findings and reconcile source dependencies
ShadowNineX Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ BenchmarkDotNet.Artifacts/
project.lock.json
project.fragment.lock.json
artifacts/
*.dll

# ASP.NET Scaffolding
ScaffoldingReadMe.txt
Expand Down
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ dotnet format whitespace CheatEngine.Mcp.slnx --no-restore --verify-no-changes

The two dependencies live in `externals/CheatEngine.Client` and `externals/CheatEngine.SDK`.
Git records their exact commits, while `.gitmodules` identifies `main` as the update branch.
Before updating, inspect each dependency with `git -C externals/CheatEngine.Client status`
and `git -C externals/CheatEngine.SDK status`. Changes inside a submodule are not included
when the parent repository is committed. Preserve them on a local branch, validate and
commit them in that repository first, then record the dependency revisions in MCP.
Do not reset a dirty dependency to make the parent status clean. Local integration commits
must be reviewed and available upstream before a release records them as dependencies.

To prepare a dependency update:

```powershell
Expand Down
8 changes: 6 additions & 2 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@
DependsOnTargets="IncludeTransitiveProjectReferences">
<ItemGroup>
<ProjectReference Update="@(ProjectReference)"
Condition="$([System.String]::Copy('%(ProjectReference.FullPath)').Contains('/externals/')) or $([System.String]::Copy('%(ProjectReference.FullPath)').Contains('\externals\'))"
AdditionalProperties="%(ProjectReference.AdditionalProperties);ShouldUnsetParentConfigurationAndPlatform=false"/>
Condition="$([System.String]::Copy('%(ProjectReference.FullPath)').Contains('/externals/')) or $([System.String]::Copy('%(ProjectReference.FullPath)').Contains('\externals\'))">
<!-- Match Client's SDK references even when building a project without a solution Platform global. -->
<SetPlatform>Platform=AnyCPU</SetPlatform>
<SetConfiguration>Configuration=$(Configuration)</SetConfiguration>
<AdditionalProperties>%(ProjectReference.AdditionalProperties);ShouldUnsetParentConfigurationAndPlatform=false</AdditionalProperties>
</ProjectReference>
</ItemGroup>
</Target>
<Import Project="$(CeMcpSdkSourceRoot)/src/CheatEngine.SDK/build/CheatEngine.SDK.targets"
Expand Down
8 changes: 4 additions & 4 deletions THIRD-PARTY-NOTICES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ Client and SDK are built from Git submodules, not restored as NuGet packages. Th

| Component | Source commit | License | Copyright | Shipped in |
|---|---|---|---|---|
| CheatEngine.Client | 9b836e6ced8e97b4506dc8523998c7c2081cc2ad | MIT | Copyright (c) 2026 AriusII, ShadowNineX and CheatEngine.Client contributors | Embedded plugin dependencies and gateway |
| CheatEngine.SDK | 09dad6c15782d9eee38f013d834d432d79e6623e | MIT | Copyright (c) 2026 AriusII, ShadowNineX and CheatEngine.SDK contributors | Six SDK runtime assemblies in the plugin and gateway; native `cheatengine-sdk-lua-bridge.dll` in the plugin |
| CheatEngine.Client | bc60c2dfc906b22bb0d2185ca3775142377d03b2 | MIT | Copyright (c) 2026 AriusII, ShadowNineX and CheatEngine.Client contributors | Embedded plugin dependencies and gateway |
| CheatEngine.SDK | 524979c2d5f9de984afd95a4dbebebc92f2ae894 | MIT | Copyright (c) 2026 AriusII, ShadowNineX and CheatEngine.SDK contributors | Six SDK runtime assemblies in the plugin and gateway; native `cheatengine-sdk-lua-bridge.dll` in the plugin |

## NuGet packages

Expand Down Expand Up @@ -64,8 +64,8 @@ SDK changes the runtime version, update this table.

| Component | Upstream license file |
|---|---|
| CheatEngine.Client | <https://github.com/CheatEngineNet/CheatEngine.Client/blob/9b836e6ced8e97b4506dc8523998c7c2081cc2ad/LICENSE> (the recorded submodule commit) |
| CheatEngine.SDK | <https://github.com/CheatEngineNet/CheatEngine.SDK/blob/09dad6c15782d9eee38f013d834d432d79e6623e/LICENSE> (the recorded submodule commit) |
| CheatEngine.Client | <https://github.com/CheatEngineNet/CheatEngine.Client/blob/bc60c2dfc906b22bb0d2185ca3775142377d03b2/LICENSE> (the recorded submodule commit) |
| CheatEngine.SDK | <https://github.com/CheatEngineNet/CheatEngine.SDK/blob/524979c2d5f9de984afd95a4dbebebc92f2ae894/LICENSE> (the recorded submodule commit) |
| Microsoft.Extensions.AI.Abstractions 10.10.1 | <https://github.com/dotnet/extensions/blob/59e1741f6fb45cf7ae08e2df088aef71537a7bc4/LICENSE> (the source commit of the package) |
| ModelContextProtocol 2.2.0 | <https://github.com/modelcontextprotocol/csharp-sdk/blob/6fa3825973949a9c4f0cd8af344e15a8db09dc35/LICENSE> and <https://github.com/modelcontextprotocol/csharp-sdk/blob/6fa3825973949a9c4f0cd8af344e15a8db09dc35/THIRD-PARTY-NOTICES.txt> (the source commit of the packages) |
| .NET runtime packs 10.0.13 | `LICENSE.TXT` and `THIRD-PARTY-NOTICES.TXT` of the runtime packs |
Expand Down
Loading
Loading