Repository navigation
Optionally (on by default) enable TCP keepalive - #74
Merged
Merged
Conversation
amitchone
changed the title
Collaborator
|
My usual question: a little bit of context on why we might want this? |
Collaborator
Author
A fair question indeed, I've updated the description with a brief overview |
Collaborator
Author
Appreciate you taking the time to look as always! |
Collaborator
|
Has Matt told you about ThingSetClassic? |
Collaborator
Author
He has now, oh my gosh 😆 There has to be a huge market for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue whereby the failure of a client to properly close a TCP connection will (eventually) cause the TCP server to silently stop accepting new connections - if a TCP connection is open and then no Finish packet is sent, the server would never free the slot and eventually the number of free slots will drop to zero with no warning or error raised
The keepalive mechanism probes (a configurable number of times) for clients that are silent (after a configurable timeout) and will close them after enough failed probe attempts, thus freeing the slot
Also bypasses this Zephyr CMake issue until we bump the Zephyr version with which we build