Repository navigation
Hand accepted sockets to handler via a queue - #75
Merged
Merged
Conversation
Collaborator
|
I think this is OK. I suppose it might be worth having Claude try to beef up the client/server tests a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acceptor thread used to write newly accepted sockets straight into the array the handler thread was polling, and because Zephyr's poll checks that array twice, when we refilled a slit mid-poll, the handler mistakes an idle client as readable and could block on it indefinitely...
Now the acceptor hands sockets over through a queue, only the handler touches these and client sockets are non-blocking.
Ultimately, after many hours of uptime we would occasionally see refused connections because there were no sockets left, even though, theoretically, "nothing" had used that many sockets
This also rounds out the keepalive fix which, after even more testing, led to this discovery and fix