Repository navigation
Stop dual-channel flush timers after streaming closes - #231
Open
codebanditssss wants to merge 1 commit into
Open
codebanditssss wants to merge 1 commit into
codebanditssss wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject dual-channel
sendAudio()when the socket is not open, matching single-channel behavior. Clear the flush interval again after the termination wait, since audio arriving during that wait can restart it. Include regression tests and the required version/changelog update.The dual-channel path currently buffers unsendable audio and starts an interval before connect or after close. That interval keeps Node alive. Sending while
close()waits can also restart the interval after its initial cleanup.Reproduction
Create a transcriber with mic/system channels and call
sendAudio(pcm, { channel: "mic" })beforeconnect(), or afterclose(false). Baseline accepts the bytes and starts an interval instead of throwing. Also send tagged audio betweenclose()sending Terminate and receiving Termination.Seven tests cover before connect, client/server close, both and partial-channel sends during termination, timeout, and normal mixing.
Validation
NODE_OPTIONS=--no-experimental-global-navigator: 590 passed.Before-connect callers now get
Socket is not open for communication; that audio was not delivered previously. Audio sent during the termination wait remains accepted.This is separate from the established-session reconnection/listener problem in issue #228.