Repository navigation
Release live request abort listeners when each request ends - #233
Open
codebanditssss wants to merge 1 commit into
Open
codebanditssss wants to merge 1 commit into
codebanditssss wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #232.
deadlineSignal()now returns{ signal, release }.release()removes the listeners on the caller's signal and the timeout.sync.transcribe(),sync.transcribeLive(),sync.openLive(),dictation.transcribeLive()anddictation.openLive()call it infinallyafterpostLive().postLive()reads the response body before returning, so cancellation and the timeout still cover the whole request.Tests
tests/unit/live-deadline-signal.test.tsuses a real local HTTP server andfetch. It covers successful and rejected requests, aborting mid-request, the timeout alongside a signal, two requests sharing one signal, aborting while a partial response body is being read, andopenLive().--no-experimental-global-navigator; default Node 22 still has the 3 existing user-agent failures). eslint, tsc, prettier, build and publint pass.Bumps the version to 4.43.6, since #230 and #231 use 4.43.5.