Repository navigation
Share overlapping streaming close calls - #230
Open
codebanditssss wants to merge 1 commit into
Open
codebanditssss wants to merge 1 commit into
codebanditssss wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share one in-flight
StreamingTranscriber.close()across overlapping callers. The first call's termination-wait options apply, and every caller gets the same result. Include regression tests and the required version/changelog update.Each close currently replaces
sessionTerminatedResolveand sends another Terminate. An earlier waiter can hang, or a later teardown can call.close()on a socket already cleared by another call.Reproduction
On an established session, call
close(true, 0)twice before the server replies with Termination. The earlier call stays pending. With finite timeouts, overlapping callers can instead throwTypeError: Cannot read properties of undefined (reading 'close').Six regression cases cover overlapping waits, timeout, mixed policies, repeated non-waiting closes, and a fresh close after completion.
Validation
NODE_OPTIONS=--no-experimental-global-navigator: 589 passed.PR #169 covers missing Termination, #192 covers close during connect, and #214 adds termination results. None shares overlapping established-session close calls.