Repository navigation
fix(streaming): emit termination and resolve close() with it - #214
Merged
Merged
Conversation
StreamingTranscriber emits a "termination" event with the server's Termination message, close() resolves with it (undefined when it did not wait or the frame did not arrive), and close() calls the close listener once for a client-initiated close before clearing listeners. Bumps to 4.43.3. Fixes #212 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccampbell-aai
marked this pull request as ready for review
November 17, 2026 01:24
bgotthold-aai
approved these changes
Nov 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccampbell-aai
added a commit
that referenced
this pull request
Nov 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #212.
StreamingTranscriberemits aterminationevent carryingTerminationEvent(audio_duration_seconds,session_duration_seconds).close()resolves with that event, orundefinedon timeout or when it doesn't wait. This matches TTSclose(). Callers who type the result asPromise<void>must widen it (noted in the CHANGELOG).close()now fires thecloselistener for a client-initiated close (code 1000), once, before clearing listeners.Test plan
tests/unit/streaming-close.test.ts(5 fail on main)tsc --noEmit, publintstreaming.assemblyai.com):terminationfires once andclose()resolves with the same object;closelistener fires exactly once forclose()(1000),close(false)(resolvesundefined) and a server-initiated 3007 close🤖 Generated with Claude Code