Repository navigation
chore: wire ruff and parallel tests into CI, and guard stdout encoding - #93
Merged
Merged
Conversation
- CI runs `ruff check skills tests` with the rule set narrowed to F, after fixing the 7 existing F findings (a duplicate dict key, an unused variable, unused imports). - Tests run in parallel with pytest-xdist (`-n auto`): about 51 s instead of 194 s locally. compileall now covers every skill's scripts. - A static test fails when a script prints `json.dumps(..., ensure_ascii=False)` to stdout, the pattern that broke cp1252 consoles. - AGENTS.md points to the companion skills, their standalone rule, and the tests that pin the formats they share with DeepPaperNote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
F, the pyflakes class.E501would add 871 findings andI001would add 46, so those stay off until the code is cleaned up."schema_version"key in a test fixture;lint_note.py;GLOSSARY_DISCLAIMER, was re-exported for a test, which now imports it fromglossary_contracts.pytest-xdistis added to thedevextra.tests/test_console_encoding.pyadds an AST check that fails if anyskills/*/scripts/*.pyprintsjson.dumps(..., ensure_ascii=False)to stdout, either directly or through a variable. This is the pattern fix: script output survives a console encoding such as cp1252 #92 fixed; CI'sPYTHONUTF8=1hides it.Evidence
ruff check skills tests --select F: 7 errors →All checks passed!python3 -m pytest -q, 1751 tests, ran serially in 194 s.python3 -m pytest -q -n autoruns 1753 tests in 51 s on 12 cores, with no failures in two runs.68793ec), flags all 6 prints that fix: script output survives a console encoding such as cp1252 #92 fixed:common.py:73run_state.py:1302aggregate_reading.py:207configure_glossary.py:45write_research_memory.py:124,126Merge Danger
Door: two-way
Blast Radius: CI only.
🤖 Generated with Claude Code